JDK-8353486 : Open source Swing Tests - Set 4

[honkar-jdk]

Open-sourced the following Swing tests:

1. javax/swing/JFileChooser/bug4464774.java
2. javax/swing/JFileChooser/bug4522756.java
3. javax/swing/JFileChooser/bug4759934.java
4. javax/swing/JFileChooser/bug4943900.java
5. javax/swing/JOptionPane/bug4194862.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353486: Open source Swing Tests - Set 4 (Bug - P4)

Reviewers

• Damon Nguyen (@DamonGuy - Committer) Review applies to fa9529dd
• Tejesh R (@TejeshR13 - Reviewer) Review applies to fa9529dd
• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24456/head:pull/24456
$ git checkout pull/24456

Update a local copy of the PR:
$ git checkout pull/24456
$ git pull https://git.openjdk.org/jdk.git pull/24456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24456

View PR using the GUI difftool:
$ git pr show -t 24456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24456.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353486: Open source Swing Tests - Set 4

Reviewed-by: azvegint, dnguyen, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 527 new commits pushed to the master branch:

• f98af0a: 8354701: Open source few JToolTip tests
• e020752: 8354484: SIGSEGV when supertype of an AOT-cached class is excluded
• 594b265: 8350126: Regression ~3% on Crypto-ChaCha20Poly1305.encrypt for MacOSX aarch64
• ... and 524 more: https://git.openjdk.org/jdk/compare/52c6ce6c73194762970fd9521121333713495fa3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 10: Full - Incremental (bb9d7649)
• 09: Full - Incremental (18419637)
• 08: Full - Incremental (a26d98e4)
• 07: Full - Incremental (fa05f0ca)
• 06: Full - Incremental (7d43f122)
• 05: Full - Incremental (5e5cbb4a)
• 04: Full - Incremental (1cd5ec66)
• 03: Full - Incremental (d9e08d09)
• 02: Full - Incremental (fa9529dd)
• 01: Full - Incremental (491a6428)
• 00: Full (be62d059)

[DamonGuy]

Thanks. I saw via your screenshots on Window how different the rows/cols can appear for the instructions. LGTM

[aivanov-jdk]

Only a partial review, I couldn't finish it today.

[aivanov-jdk]

Is the intention to run in system L&F only rather than in all L&Fs?

[honkar-jdk]

The original bug was on GTK+linux only. I have extended it to SystemLookAndFeel. Since there are slight variations on how the file filter works on different LaF and the test instructions would be confusing if we were to account for all variations of installed LaF. Hence limited it System LaF. For example on macOS (Aqua LaF) when the txt filter is applied non-text files are greyed out.

[aivanov-jdk]

Looks good except for minor nits.

[honkar-jdk]

/integrate

[openjdk]

Going to push as commit 486a664.
Since your change was applied there have been 527 commits pushed to the master branch:

• f98af0a: 8354701: Open source few JToolTip tests
• e020752: 8354484: SIGSEGV when supertype of an AOT-cached class is excluded
• 594b265: 8350126: Regression ~3% on Crypto-ChaCha20Poly1305.encrypt for MacOSX aarch64
• ... and 524 more: https://git.openjdk.org/jdk/compare/52c6ce6c73194762970fd9521121333713495fa3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk Pushed as commit 486a664.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.