-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8353589: Open source a few Swing menu-related tests #24457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 265 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
honkar-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than minor inline comments.
jayathirthrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Also tested them on my macOS machine.
|
/integrate |
|
Going to push as commit 98dac46.
Your commit was automatically rebased without conflicts. |
Open source a few tests related to Swing menus.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24457/head:pull/24457$ git checkout pull/24457Update a local copy of the PR:
$ git checkout pull/24457$ git pull https://git.openjdk.org/jdk.git pull/24457/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24457View PR using the GUI difftool:
$ git pr show -t 24457Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24457.diff
Using Webrev
Link to Webrev Comment