8353713: Improve Currency.getInstance exception handling

[justin-curtis-lu]

Please review this PR which improves some Currency IllegalArgumentExceptions by including the input in the message. This could be a currency code, country code, or locale. This change also includes tests to check the messages for an invalid country via the region override as well as an invalid country code within a 3 length currency code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353713: Improve Currency.getInstance exception handling (Enhancement - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24459/head:pull/24459
$ git checkout pull/24459

Update a local copy of the PR:
$ git checkout pull/24459
$ git pull https://git.openjdk.org/jdk.git pull/24459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24459

View PR using the GUI difftool:
$ git pr show -t 24459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24459.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353713: Improve Currency.getInstance exception handling

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 867a030: 8352971: Increase maximum number of hold counts for ReentrantReadWriteLock
• 9a391f4: 8353278: Consolidate local file URL checks in jar: and file: URL schemes
• 4021033: 8353659: SubmissionPublisherTest::testCap1Submit times out
• 60fbf73: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
• 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
• 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
• 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
• 66435c2: 8352684: Opensource JInternalFrame tests - series1
• 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
• 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
• ... and 17 more: https://git.openjdk.org/jdk/compare/3cc43b3224efdf1a3f35fff58b993027a9e1f4ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dab5091b)
• 00: Full (e79241d0)

[naotoj]

Looks good.

[naotoj]

Since the test is not parameterized, we can simply use ".." inside the expected string literal.

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit 5cac579.
Since your change was applied there have been 63 commits pushed to the master branch:

• e1a4a6b: 8340185: Use make -k on GHA to catch more build errors
• bd73a06: 8300339: Run jtreg in the work dir
• b98d6ae: 8339527: Adjust threshold for MemorySegment::fill native invocation
• ... and 60 more: https://git.openjdk.org/jdk/compare/3cc43b3224efdf1a3f35fff58b993027a9e1f4ad...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 5cac579.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.