Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261231: Windows IME was disabled after DnD operation #2448

Closed
wants to merge 1 commit into from

Conversation

@dmarkov20
Copy link
Member

@dmarkov20 dmarkov20 commented Feb 7, 2021

The function InvokeInputMethodFunction() is responsible for invocation of IME API. Typically it uses PostMessage() to execute corresponding IME function on the toolkit thread but if DnD operation takes place SendMessage() is used. The state of m_inputMethodWaitEvent event object remains signalled after SendMessage() execution. That causes failure of subsequent IME functions calls via PostMessage().

Fix:
SendMessage() and PostMessage() calls inside InvokeInputMethodFunction() should be synchronised. The state of m_inputMethodWaitEvent event object must be reseted right after SendMessage() execution.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261231: Windows IME was disabled after DnD operation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2448/head:pull/2448
$ git checkout pull/2448

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 7, 2021

👋 Welcome back dmarkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 7, 2021

@dmarkov20 The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d awt labels Feb 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 7, 2021

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Change looks good and i haven't found any side-effects during testing. Could you please add the label to the bug noting reason for absence of the regression test, like noreg-hard or something?

@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@dmarkov20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261231: Windows IME was disabled after DnD operation

Reviewed-by: kizune, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 48c932e: 8231286: HTML font size too large with high-DPI scaling and W3C_LENGTH_UNITS
  • dbc35f6: 8261094: Open javax/swing/text/html/CSS/4765271/bug4765271.java
  • db0ca2b: 8261161: Clean up warnings in hotspot/jtreg/vmTestbase tests
  • 2c28e36: 8237352: Update DatagramSocket to add support for joining multicast groups
  • d0a8f2f: 8260593: javac can skip a temporary local variable when pattern matching over a local variable
  • deb0544: 8261251: Shenandoah: Use object size for full GC humongous compaction
  • d45343e: 8260899: ARM32: SyncOnValueBasedClassTest fails with assert(is_valid()) failed: invalid register
  • 9d59dec: 8248876: LoadObject with bad base address created for exec file on linux
  • aa5bc6e: 8258953: AArch64: move NEON instructions to aarch64_neon.ad

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 8, 2021
@takiguc
Copy link

@takiguc takiguc commented Feb 8, 2021

I also tested this fix. It worked fine. Thanks.

mrserb
mrserb approved these changes Feb 8, 2021
@dmarkov20
Copy link
Member Author

@dmarkov20 dmarkov20 commented Feb 8, 2021

Change looks good and i haven't found any side-effects during testing. Could you please add the label to the bug noting reason for absence of the regression test, like noreg-hard or something?

Thank you for the review. I have added noreg-hard to the bug

@dmarkov20
Copy link
Member Author

@dmarkov20 dmarkov20 commented Feb 8, 2021

/integrate

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@dmarkov20 Since your change was applied there have been 10 commits pushed to the master branch:

  • 29a428f: 8261229: MethodData is not correctly initialized with TieredStopAtLevel=3
  • 48c932e: 8231286: HTML font size too large with high-DPI scaling and W3C_LENGTH_UNITS
  • dbc35f6: 8261094: Open javax/swing/text/html/CSS/4765271/bug4765271.java
  • db0ca2b: 8261161: Clean up warnings in hotspot/jtreg/vmTestbase tests
  • 2c28e36: 8237352: Update DatagramSocket to add support for joining multicast groups
  • d0a8f2f: 8260593: javac can skip a temporary local variable when pattern matching over a local variable
  • deb0544: 8261251: Shenandoah: Use object size for full GC humongous compaction
  • d45343e: 8260899: ARM32: SyncOnValueBasedClassTest fails with assert(is_valid()) failed: invalid register
  • 9d59dec: 8248876: LoadObject with bad base address created for exec file on linux
  • aa5bc6e: 8258953: AArch64: move NEON instructions to aarch64_neon.ad

Your commit was automatically rebased without conflicts.

Pushed as commit d6d5d9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dmarkov20 dmarkov20 deleted the JDK-8261231-fix branch Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants