8244533: Configure should abort on missing short names in Windows

[magicus]

Windows can create short names for directories that contain spaces in the name.

However, where short name creation was previously enabled by default, it no longer seems to be in recent version of Windows (the default setting is instead 'per volume', and the default for each volume is 'off').

We should check that the output paths of these utility macros are actually space-free, and emit an error otherwise. We should also add additional documentation about short names, and the short name creation setting to doc/building.md.

When testing this in several different cases with path including spaces that either had or had not a short name, it became apparent that the current handling of such cases were not ... optimal. Hence some bug fixes were needed to properly handle such cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8244533: Configure should abort on missing short names in Windows (Enhancement - P3)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Contributors

• Jorn Vernee <jvernee@openjdk.org>
• Magnus Ihse Bursie <ihse@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24483/head:pull/24483
$ git checkout pull/24483

Update a local copy of the PR:
$ git checkout pull/24483
$ git pull https://git.openjdk.org/jdk.git pull/24483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24483

View PR using the GUI difftool:
$ git pr show -t 24483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24483.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244533: Configure should abort on missing short names in Windows

Co-authored-by: Jorn Vernee <jvernee@openjdk.org>
Co-authored-by: Magnus Ihse Bursie <ihse@openjdk.org>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 8c1b915: 8356126: Duplication handling and optimization of CaptureCallState
• 3f6b177: 8332934: Do loop with continue with subsequent switch leads to incorrect stack maps
• cb02158: 8354461: Update tests to disable streaming output for attach tools
• ... and 15 more: https://git.openjdk.org/jdk/compare/b5fd289f53e8380dfc38c3615acd10396ac647d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[magicus]

/contributor add jvernee

[openjdk]

@magicus
Contributor Jorn Vernee <jvernee@openjdk.org> successfully added.

[magicus]

/contributor add ihse

[openjdk]

@magicus
Contributor Magnus Ihse Bursie <ihse@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 02: Full - Incremental (b3e6d2ec)
• 01: Full - Incremental (45a94bfe)
• 00: Full (210aa040)

[erikj79]

This is a great change. Just a minor grammar nit in the docs.

[magicus]

/integrate

[openjdk]

Going to push as commit 493ac93.
Since your change was applied there have been 18 commits pushed to the master branch:

• 8c1b915: 8356126: Duplication handling and optimization of CaptureCallState
• 3f6b177: 8332934: Do loop with continue with subsequent switch leads to incorrect stack maps
• cb02158: 8354461: Update tests to disable streaming output for attach tools
• ... and 15 more: https://git.openjdk.org/jdk/compare/b5fd289f53e8380dfc38c3615acd10396ac647d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 493ac93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.