Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253350: Remove unimplemented SharedRuntime::clean_*_entry #245

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 18, 2020

Their existence seems to predate OpenJDK. There are no uses, no definitions.

Testing:

  • Linux x86_64 fastdebug build
  • Text searches for clean_*_entry in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253350: Remove unimplemented SharedRuntime::clean_*_entry

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/245/head:pull/245
$ git checkout pull/245

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253350: Remove unimplemented SharedRuntime::clean_*_entry

Reviewed-by: zgu, coleenp
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 43019a0e6b29e2e63c668f60b5758ca5daafab96.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also appears trivial.

@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev Since your change was applied there have been 4 commits pushed to the master branch:

  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses

Your commit was automatically rebased without conflicts.

Pushed as commit 05572e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253350-shr-clean-entry branch September 21, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants