8261072: AArch64: Fix MacroAssembler::get_thread convention

[AntonKozlov]

Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).

Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261072: AArch64: Fix MacroAssembler::get_thread convention

Reviewers

• Bernhard Urban-Forster (@lewurm - Author) ⚠️ Review applies to 217d3c2
• Andrew Haley (@theRealAph - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2451/head:pull/2451
$ git checkout pull/2451

[bridgekeeper]

👋 Welcome back akozlov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AntonKozlov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3b111ae)
• 00: Full (217d3c2)

[VladimirKempik]

Looks good, will make other non-linux platform work without the need to change this ever again

[openjdk]

@AntonKozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261072: AArch64: Fix MacroAssembler::get_thread convention

Reviewed-by: burban, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

• 59b8d59: 8261481: Cannot read Kerberos settings in dynamic store on macOS Big Sur
• 9f81ca8: 8261230: GC tracing of page sizes are wrong in a few places
• 40ae993: 8261027: AArch64: Support for LSE atomics C++ HotSpot code
• 9ffabf3: 8252971: WindowsFileAttributes does not know about Unix domain sockets
• 682e78e: 8261071: AArch64: Refactor interpreter native wrappers
• ebaa58d: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
• 3210095: 8261079: Fix support for @hidden in classes and interfaces
• 9c0ec8d: 8260941: Remove the conc_scan parameter for CardTable
• da9895a: 8261499: Simplify HTML for javadoc links
• 0779add: 8255059: Regressions >5% in all Javadoc benchmarks in 16-b19
• ... and 86 more: https://git.openjdk.java.net/jdk/compare/48f5220c8018f9c166df8d49ce1eb2070695d961...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[AntonKozlov]

/reviewer vkempik
/integrate

[openjdk]

@AntonKozlov Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[openjdk]

@AntonKozlov
Your change (at version 3b111ae) is now ready to be sponsored by a Committer.

[VladimirKempik]

/sponsor

[openjdk]

@VladimirKempik @AntonKozlov Since your change was applied there have been 96 commits pushed to the master branch:

• 59b8d59: 8261481: Cannot read Kerberos settings in dynamic store on macOS Big Sur
• 9f81ca8: 8261230: GC tracing of page sizes are wrong in a few places
• 40ae993: 8261027: AArch64: Support for LSE atomics C++ HotSpot code
• 9ffabf3: 8252971: WindowsFileAttributes does not know about Unix domain sockets
• 682e78e: 8261071: AArch64: Refactor interpreter native wrappers
• ebaa58d: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
• 3210095: 8261079: Fix support for @hidden in classes and interfaces
• 9c0ec8d: 8260941: Remove the conc_scan parameter for CardTable
• da9895a: 8261499: Simplify HTML for javadoc links
• 0779add: 8255059: Regressions >5% in all Javadoc benchmarks in 16-b19
• ... and 86 more: https://git.openjdk.java.net/jdk/compare/48f5220c8018f9c166df8d49ce1eb2070695d961...master

Your commit was automatically rebased without conflicts.

Pushed as commit b670efd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.