8354121: Use a record class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction

[minborg]

This PR proposes to use an anonymous class rather than a lambda in order to improve startup time.

We need to make sure the regression is fixed by this. It might be the case that the regression is there because JDK-8347047 actually fixed an issue so that the segments could be collected by the GC.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354121: Use a record class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24514/head:pull/24514
$ git checkout pull/24514

Update a local copy of the PR:
$ git checkout pull/24514
$ git pull https://git.openjdk.org/jdk.git pull/24514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24514

View PR using the GUI difftool:
$ git pr show -t 24514

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24514.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354121: Use a record class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 9d8b93b: 8354181: [Backout] 8334046: Set different values for CompLevel_any and CompLevel_all
• da462cf: 8353692: Relax memory constraint on updating ObjectMonitorTable's item count
• f9d705b: 8351757: Test java/foreign/TestDeadlock.java#FileChannel_map timed out after passing
• ... and 5 more: https://git.openjdk.org/jdk/compare/250eb743c112fbcc45bf2b3ded1c644b19893577...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (730c064f)
• 01: Full - Incremental (49c4b352)
• 00: Full (98975dc9)

[liach]

@minborg Can we just use a local record to avoid accidental local captures (which caused the issue fixed by JDK-8347407)

[liach]

Thanks for this error-proof improvement. Remember to update the JBS issue and PR titles.

[minborg]

/integrate

[openjdk]

Going to push as commit c3e0439.
Since your change was applied there have been 8 commits pushed to the master branch:

• 9d8b93b: 8354181: [Backout] 8334046: Set different values for CompLevel_any and CompLevel_all
• da462cf: 8353692: Relax memory constraint on updating ObjectMonitorTable's item count
• f9d705b: 8351757: Test java/foreign/TestDeadlock.java#FileChannel_map timed out after passing
• ... and 5 more: https://git.openjdk.org/jdk/compare/250eb743c112fbcc45bf2b3ded1c644b19893577...master

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit c3e0439.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.