Skip to content

Conversation

@koushikthirupattur
Copy link
Contributor

@koushikthirupattur koushikthirupattur commented Apr 8, 2025

Update copyright in NameFormat.java fix after JDK-8353945. Missed to update when the fix was integrated with JDK-8353945.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

  • JDK-8354061: Update copyright in NameFormat.java fix after JDK-8349890 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24518/head:pull/24518
$ git checkout pull/24518

Update a local copy of the PR:
$ git checkout pull/24518
$ git pull https://git.openjdk.org/jdk.git pull/24518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24518

View PR using the GUI difftool:
$ git pr show -t 24518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24518.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2025

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@koushikthirupattur The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 8, 2025
@liach
Copy link
Member

liach commented Apr 8, 2025

/reviewers 2 reviewer

On second look this is not necessary - this file was not touched.

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2025

Webrevs

@koushikthirupattur koushikthirupattur deleted the 8354061 branch April 8, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants