Skip to content

Conversation

@koushikthirupattur
Copy link
Contributor

@koushikthirupattur koushikthirupattur commented Apr 8, 2025

8354061: Update copyright in NameFormat.java fix after JDK-8349890


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354061: Update copyright in NameFormat.java fix after JDK-8349890 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24523/head:pull/24523
$ git checkout pull/24523

Update a local copy of the PR:
$ git checkout pull/24523
$ git pull https://git.openjdk.org/jdk.git pull/24523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24523

View PR using the GUI difftool:
$ git pr show -t 24523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24523.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2025

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@koushikthirupattur This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354061: Update copyright in NameFormat.java fix after JDK-8349890

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@koushikthirupattur The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 8, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

⚠️ @koushikthirupattur the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jdk-8354061
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2025
@koushikthirupattur
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@koushikthirupattur
Your change (at version 1d3078e) is now ready to be sponsored by a Committer.

@liach
Copy link
Member

liach commented Apr 8, 2025

This trivial bump looks right.

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

Going to push as commit 63fa255.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5b42c46: 8353757: Log class should have a proper clear() method

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2025
@openjdk openjdk bot closed this Apr 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@liach @koushikthirupattur Pushed as commit 63fa255.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants