8352748: Remove com.sun.tools.classfile from the JDK

[liach]

With all dependencies of com.sun.tools.classfile in the JDK converted to the ClassFile API, we can remove this legacy library for release 25 like how we removed ASM.

Testing: built locally, running tier 1-3 tests

Don't know why, but GitHub is redundantly displaying changes that are already in #24212.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8352748: Remove com.sun.tools.classfile from the JDK (Sub-task - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24528/head:pull/24528
$ git checkout pull/24528

Update a local copy of the PR:
$ git checkout pull/24528
$ git pull https://git.openjdk.org/jdk.git pull/24528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24528

View PR using the GUI difftool:
$ git pr show -t 24528

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24528.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into pr/24212 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352748: Remove com.sun.tools.classfile from the JDK

Reviewed-by: ihse, jlahoda, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 5f2a604: 8353840: JNativeScan should not abort for missing classes
• 1f21da7: 8351462: Improve robustness of String concatenation
• 567c688: 8353597: Refactor handling VM options for AOT cache input and output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (4beb18da)
• 00: Full (ba2ce182)

[liach]

Tier 1-3 tests passed, only unrelated failure fixed by 8354088.

[magicus]

Build changes look trivially fine.

/reviewers 2

[openjdk]

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[liach]

/reviewers 2 reviewer

[openjdk]

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout feature/remove-old-classfile
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[lahodaj]

Looks good to me. I won't increase the reviewer count, but please wait a few days to give others chance to comment if they choose to.

[vicente-romero-oracle]

lgtm

[liach]

Tier 1-3 tests all pass. Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 5c438c5.
Since your change was applied there have been 11 commits pushed to the master branch:

• e87ff32: 8351034: Add AVX-512 intrinsics for ML-DSA
• e3f26b0: 8351319: AOT cache support for custom class loaders broken since JDK-8348426
• 4954a33: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint
• ... and 8 more: https://git.openjdk.org/jdk/compare/4dc9e58906772bf8ee444cb1618aa43f66593d79...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 5c438c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.