Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath #2453

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 8, 2021

SonarCloud instance reports a new warning after JDK-8254702:
"Use of memory after it is freed"

char* getJvmLauncherLibPath(void) {
       ...
        popenStatus = popenCommand(pkgQueryCmd, pkg->name, findLauncherLib,
                                                        &launcherLibPath);
        if (popenStatus) {
            free(launcherLibPath); <---- frees here
            goto cleanup;
        }
    }

cleanup:
    free(modulePath);
    freePackageDesc(pkg);

    return launcherLibPath; <--- here
}

We need to null it out before returning.

Additional testing:

  • Linux x86_64 (Ubuntu) tools/jpackage

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2453/head:pull/2453
$ git checkout pull/2453

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@shipilev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 8, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2021

Webrevs

@tstuefe
Copy link
Member

tstuefe commented Feb 8, 2021

Fine and trivial. Thanks for fixing.

I tried to understand what the fix for JDK-8254702 does but the issue description and the PR are a bit taciturn. This seems to be way more than just a split of C- and C++ sources as the PR suggested.

..Thomas

@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath

Reviewed-by: stuefe, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2021
@shipilev
Copy link
Member Author

shipilev commented Feb 9, 2021

jpackage reviewers, please? @andyherrick?

@shipilev
Copy link
Member Author

shipilev commented Feb 9, 2021

Thanks!

/integrate

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@shipilev Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 01d9280.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8261299-jpackage-use-after-free branch February 15, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants