8352682: Opensource JComponent tests#24562
Conversation
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
|
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 431 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
| private static synchronized boolean failed() { | ||
| return !passFlag; | ||
| } | ||
| private static synchronized void fail() { |
There was a problem hiding this comment.
I think these methods are a bit redundant, just add more code to read and understand. What about removing them and just renaming the flags failed and traced?
What do you think?
There was a problem hiding this comment.
I agree traceFlag and passFlag are declared as volatile vars , so all four synchronized methods look redundant and can be removed to simplify the code.
These vars can be converted to CountDownLatch for stability.
There was a problem hiding this comment.
Ok. Redundant methods removed...utiliesed the vars..
CountDownLatch not needed as there's not indeterministic sleep in it, it is relying on flags which are deterministic in itself..
| private static synchronized boolean failed() { | ||
| return !passFlag; | ||
| } | ||
| private static synchronized void fail() { |
There was a problem hiding this comment.
I agree traceFlag and passFlag are declared as volatile vars , so all four synchronized methods look redundant and can be removed to simplify the code.
These vars can be converted to CountDownLatch for stability.
|
/integrate |
|
Going to push as commit 55afcb5.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
5 participants
Few JComponent tests are opensourced
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24562/head:pull/24562$ git checkout pull/24562Update a local copy of the PR:
$ git checkout pull/24562$ git pull https://git.openjdk.org/jdk.git pull/24562/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24562View PR using the GUI difftool:
$ git pr show -t 24562Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24562.diff
Using Webrev
Link to Webrev Comment