8354024: [JMH] Create ephemeral UnixDomainSocketAddress provider with thread-safe close semantics

[vy]

ServerUdsChannelHolder is introduced to manage the life cycle of a ServerSocketChannel created using Unix domain sockets (UDS) in a thread-safe manner.

Testing

Changes can be tested as follows:

make build-microbenchmark
build/linux-x64/jdk/bin/java \
  -jar build/linux-x64/images/test/micro/benchmarks.jar \
  -f 1 -wi 1 -i 1 -t 2 \
  "(SocketChannelConnectionSetup|UnixSocketChannelReadWrite)"

Background

A UDS need to be pointed to a non-existent file, which is to be created by bind(). The created file needs to be deleted as a part of the clean-up at exit. When tests employing UDS run in parallel, failures can happen at multiple places:

• bind() can fail, if the file is already created by another thread
• the clean-up of the socket file can fail, if the file is already deleted
  • reported for SocketChannelConnectionSetup in 8350915
  • reported for UnixSocketChannelReadWrite in 8351601
• the clean-up of the socket file parent directory can fail, if not all threads deleted their socket files, and hence, the folder is not empty
  • reported for in SocketChannelConnectionSetup in 8354024

This PR introduces ServerUdsChannelHolder utility to manage the life cycle of a UDS and avoids above shared issues by:

• using a dedicated (temporary and unique) parent folder for the socket
• encapsulating the termination logic (i.e., closing the socket, deleting the socket file and its (dedicated) parent folder) in AutoCloseable::close

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354024: [JMH] Create ephemeral UnixDomainSocketAddress provider with thread-safe close semantics (Enhancement - P4)

Reviewers

• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24568/head:pull/24568
$ git checkout pull/24568

Update a local copy of the PR:
$ git checkout pull/24568
$ git pull https://git.openjdk.org/jdk.git pull/24568/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24568

View PR using the GUI difftool:
$ git pr show -t 24568

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24568.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354024: [JMH] Create ephemeral UnixDomainSocketAddress provider with thread-safe close semantics

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 03dca03: 8354908: javac mishandles supplementary character in character literal
• 6e08469: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out
• 24d77ad: 8356057: PrintingProcessor (-Xprint) does not print type variable bounds and type annotations for Object supertypes
• ... and 7 more: https://git.openjdk.org/jdk/compare/45dfc2c6d6d6b2b0749347b0150bb22d49f12767...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sendaoYan, @Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (07675a43)
• 04: Full - Incremental (d830ec8b)
• 03: Full - Incremental (ffd31a46)
• 02: Full - Incremental (0b33d932)
• 01: Full - Incremental (57e7ed7d)
• 00: Full (19be0e7a)

[sendaoYan]

2020, seems do not needed?

[vy]

2020, seems do not needed?

@sendaoYan, thanks. Removed in 57e7ed7.

[Michael-Mc-Mahon]

Looks fine to me

[vy]

/integrate

[openjdk]

@vy
Your change (at version 07675a4) is now ready to be sponsored by a Committer.

[Michael-Mc-Mahon]

/sponsor

[openjdk]

Going to push as commit 7dcc386.
Since your change was applied there have been 17 commits pushed to the master branch:

• 85db463: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object
• 38bb8ad: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• 8ffc121: 8356774: AArch64: StubGen final stubs buffer too small for ZGC on Cavium CPU
• ... and 14 more: https://git.openjdk.org/jdk/compare/45dfc2c6d6d6b2b0749347b0150bb22d49f12767...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Michael-Mc-Mahon @vy Pushed as commit 7dcc386.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.