Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702 #2459

Closed

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 8, 2021

Remove accidently added Linux build flags


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2459/head:pull/2459
$ git checkout pull/2459

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 8, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Feb 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 8, 2021

Webrevs

erikj79
erikj79 approved these changes Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 8, 2021
@alexeysemenyukoracle
Copy link
Member Author

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 8, 2021

/integrate

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@alexeysemenyukoracle Since your change was applied there have been 8 commits pushed to the master branch:

  • 2fd8ed0: 8240632: Note differences between IEEE 754-2019 math lib special cases and java.lang.Math
  • ace8f94: 8195744: Avoid calling ClassLoader.checkPackageAccess if security manager is not installed
  • ab65d53: 8261261: The version extra fields needs to be overridable in jib-profiles.js
  • 20d7713: 8261334: NMT: tuning statistic shows incorrect hash distribution
  • 92c6e6d: 8261254: Initialize charset mapping data lazily
  • 351d788: 8259074: regex benchmarks and tests
  • d6d5d9b: 8261231: Windows IME was disabled after DnD operation
  • 29a428f: 8261229: MethodData is not correctly initialized with TieredStopAtLevel=3

Your commit was automatically rebased without conflicts.

Pushed as commit ad525bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8261281 branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants