-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8353592: Open source several scrollbar tests #24590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
azvegint
wants to merge
1
commit into
openjdk:master
from
azvegint:testsprint_2025_03/8353592_scrollbar_tests
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * Copyright (c) 1998, 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 4029465 | ||
| * @summary Win95 Multiselect List doesn't display scrollbar | ||
| * @key headful | ||
| * @run main ListScrollbarTest | ||
| */ | ||
|
|
||
| import java.awt.Color; | ||
| import java.awt.Dimension; | ||
| import java.awt.EventQueue; | ||
| import java.awt.Frame; | ||
| import java.awt.List; | ||
| import java.awt.Point; | ||
| import java.awt.Rectangle; | ||
| import java.awt.Robot; | ||
|
|
||
| public class ListScrollbarTest { | ||
|
|
||
| private static final Color BG_COLOR = Color.RED; | ||
| private static Robot robot; | ||
| private static Frame frame; | ||
| private static List list; | ||
| private static int counter = 0; | ||
| private static volatile Rectangle listBounds; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| try { | ||
| EventQueue.invokeAndWait(ListScrollbarTest::createAndShowUI); | ||
| test(); | ||
| } finally { | ||
| EventQueue.invokeAndWait(() -> { | ||
| if (frame != null) { | ||
| frame.dispose(); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private static void test() throws Exception { | ||
| robot = new Robot(); | ||
| robot.waitForIdle(); | ||
| robot.delay(500); | ||
|
|
||
| EventQueue.invokeAndWait(() -> { | ||
| Point locationOnScreen = list.getLocationOnScreen(); | ||
| Dimension size = list.getSize(); | ||
| listBounds = new Rectangle(locationOnScreen, size); | ||
| }); | ||
|
|
||
| Point point = new Point(listBounds.x + listBounds.width - 5, | ||
| listBounds.y + listBounds.height / 2); | ||
|
|
||
|
|
||
| for (int i = 0; i < 4; i++) { | ||
| scrollbarCheck(point, false); | ||
| addListItem(); | ||
| } | ||
| scrollbarCheck(point, true); | ||
| } | ||
|
|
||
| public static boolean areColorsSimilar(Color c1, Color c2, int tolerance) { | ||
| return Math.abs(c1.getRed() - c2.getRed()) <= tolerance | ||
| && Math.abs(c1.getGreen() - c2.getGreen()) <= tolerance | ||
| && Math.abs(c1.getBlue() - c2.getBlue()) <= tolerance; | ||
| } | ||
|
|
||
| private static void scrollbarCheck(Point point, boolean isScrollbarExpected) { | ||
| Color pixelColor = robot.getPixelColor(point.x, point.y); | ||
| boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mino : tolerance can be declared as static final var
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep it local as it is only used once. |
||
|
|
||
| if (isScrollbarExpected && areColorsSimilar) { | ||
| throw new RuntimeException((""" | ||
| Scrollbar is expected, but pixel color \ | ||
| is similar to the background color | ||
| %s pixel color | ||
| %s bg color""") | ||
| .formatted(pixelColor, BG_COLOR)); | ||
| } | ||
|
|
||
| if (!isScrollbarExpected && !areColorsSimilar) { | ||
| throw new RuntimeException((""" | ||
| Scrollbar is not expected, but pixel color \ | ||
| is not similar to the background color | ||
| %s pixel color | ||
| %s bg color""") | ||
| .formatted(pixelColor, BG_COLOR)); | ||
| } | ||
| } | ||
|
|
||
| private static void addListItem() throws Exception { | ||
| EventQueue.invokeAndWait(() -> { | ||
| counter++; | ||
| System.out.println("Adding list item " + counter); | ||
| list.add("List Item " + counter); | ||
| frame.validate(); | ||
| }); | ||
| robot.waitForIdle(); | ||
| robot.delay(150); | ||
| } | ||
|
|
||
| private static void createAndShowUI() { | ||
| frame = new Frame("ListScrollbarTest"); | ||
| list = new List(3, true); | ||
| list.setBackground(BG_COLOR); | ||
|
|
||
| // do not draw border around items, it can affect screen capture | ||
| list.setFocusable(false); | ||
|
|
||
| frame.add(list); | ||
|
|
||
| frame.pack(); | ||
| frame.setLocationRelativeTo(null); | ||
| frame.setVisible(true); | ||
| } | ||
| } | ||
114 changes: 114 additions & 0 deletions
114
test/jdk/java/awt/Scrollbar/ScrollbarCtrlClickTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright (c) 2002, 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 4075950 | ||
| * @summary Test for functionality of Control Click on Scrollbar | ||
| * @key headful | ||
| * @run main ScrollbarCtrlClickTest | ||
| */ | ||
|
|
||
| import java.awt.BorderLayout; | ||
| import java.awt.Dimension; | ||
| import java.awt.EventQueue; | ||
| import java.awt.Frame; | ||
| import java.awt.Point; | ||
| import java.awt.Rectangle; | ||
| import java.awt.Robot; | ||
| import java.awt.Scrollbar; | ||
| import java.awt.TextArea; | ||
| import java.awt.event.KeyEvent; | ||
| import java.awt.event.MouseEvent; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| public class ScrollbarCtrlClickTest { | ||
| private static Frame frame; | ||
| private static TextArea ta; | ||
| private static Scrollbar scrollbar; | ||
| private static final CountDownLatch latch = new CountDownLatch(1); | ||
| private static volatile Rectangle sbBounds; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| try { | ||
| EventQueue.invokeAndWait(ScrollbarCtrlClickTest::initAndShowGUI); | ||
| test(); | ||
| } finally { | ||
| EventQueue.invokeAndWait(() -> { | ||
| if (frame != null) { | ||
| frame.dispose(); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private static void initAndShowGUI() { | ||
| frame = new Frame("ScrollbarDimensionTest"); | ||
| ta = new TextArea("", 30, 100); | ||
|
|
||
|
|
||
| scrollbar = new Scrollbar(Scrollbar.VERTICAL, | ||
| 0, 10, 0, 20); | ||
|
|
||
| // Just setting layout so scrollbar thumb will be big enough to use | ||
| frame.setLayout(new BorderLayout()); | ||
| frame.add("East", scrollbar); | ||
| frame.add("West", ta); | ||
|
|
||
| scrollbar.addAdjustmentListener(e -> { | ||
| System.out.println(e.paramString()); | ||
| ta.append(e.paramString() + "\n"); | ||
| latch.countDown(); | ||
| }); | ||
|
|
||
| frame.pack(); | ||
| frame.setLocationRelativeTo(null); | ||
| frame.setVisible(true); | ||
| } | ||
|
|
||
| private static void test() throws Exception { | ||
| Robot robot = new Robot(); | ||
| robot.waitForIdle(); | ||
| robot.setAutoDelay(25); | ||
| robot.delay(500); | ||
|
|
||
| EventQueue.invokeAndWait(() -> { | ||
| Point locationOnScreen = scrollbar.getLocationOnScreen(); | ||
| Dimension size = scrollbar.getSize(); | ||
| sbBounds = new Rectangle(locationOnScreen, size); | ||
| }); | ||
|
|
||
| robot.mouseMove(sbBounds.x + sbBounds.width / 2, | ||
| sbBounds.y + sbBounds.height - 50); | ||
|
|
||
| robot.keyPress(KeyEvent.VK_CONTROL); | ||
| robot.mousePress(MouseEvent.BUTTON1_DOWN_MASK); | ||
| robot.mouseRelease(MouseEvent.BUTTON1_DOWN_MASK); | ||
| robot.keyRelease(KeyEvent.VK_CONTROL); | ||
|
|
||
| if (!latch.await(1, TimeUnit.SECONDS)) { | ||
| throw new RuntimeException("Timed out waiting for latch"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| /* | ||
| * Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 4169461 | ||
| * @summary Test for Motif Scrollbar unit increment | ||
| * @key headful | ||
| * @run main UnitIncrementTest | ||
| */ | ||
|
|
||
| import javax.swing.UIManager; | ||
| import java.awt.Dimension; | ||
| import java.awt.EventQueue; | ||
| import java.awt.Frame; | ||
| import java.awt.Point; | ||
| import java.awt.Rectangle; | ||
| import java.awt.Robot; | ||
| import java.awt.Scrollbar; | ||
| import java.awt.event.AdjustmentEvent; | ||
| import java.awt.event.MouseEvent; | ||
| import java.util.ArrayList; | ||
|
|
||
| public class UnitIncrementTest { | ||
| private static Frame frame; | ||
| private static Scrollbar scrollbar; | ||
| private static final java.util.List<AdjustmentEvent> eventsList = new ArrayList<>(); | ||
| private static final int UNIT_INCREMENT_VALUE = 5; | ||
| private static final int INCREMENTS_COUNT = 10; | ||
| private static volatile Rectangle scrollbarBounds; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| UIManager.setLookAndFeel("com.sun.java.swing.plaf.motif.MotifLookAndFeel"); | ||
|
|
||
| try { | ||
| EventQueue.invokeAndWait(UnitIncrementTest::createAndShowUI); | ||
| test(); | ||
| } finally { | ||
| EventQueue.invokeAndWait(() -> { | ||
| if (frame != null) { | ||
| frame.dispose(); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private static void createAndShowUI() { | ||
| frame = new Frame("UnitIncrementTest"); | ||
|
|
||
| scrollbar = new Scrollbar(Scrollbar.HORIZONTAL); | ||
|
|
||
| scrollbar.setUnitIncrement(UNIT_INCREMENT_VALUE); | ||
| scrollbar.setBlockIncrement(20); | ||
|
|
||
| scrollbar.addAdjustmentListener(e -> { | ||
| eventsList.add(e); | ||
| System.out.println(e); | ||
| }); | ||
|
|
||
| frame.add(scrollbar); | ||
|
|
||
| frame.setSize(300, 100); | ||
| frame.setLocationRelativeTo(null); | ||
| frame.setVisible(true); | ||
| } | ||
|
|
||
| private static void test() throws Exception { | ||
| Robot robot = new Robot(); | ||
| robot.waitForIdle(); | ||
| robot.setAutoDelay(25); | ||
| robot.delay(500); | ||
|
|
||
| EventQueue.invokeAndWait(() -> { | ||
| Point locationOnScreen = scrollbar.getLocationOnScreen(); | ||
| Dimension size = scrollbar.getSize(); | ||
| scrollbarBounds = new Rectangle(locationOnScreen, size); | ||
| }); | ||
|
|
||
| robot.mouseMove(scrollbarBounds.x + scrollbarBounds.width - 10, | ||
| scrollbarBounds.y + scrollbarBounds.height / 2); | ||
|
|
||
| for (int i = 0; i < INCREMENTS_COUNT; i++) { | ||
| robot.mousePress(MouseEvent.BUTTON1_DOWN_MASK); | ||
| robot.mouseRelease(MouseEvent.BUTTON1_DOWN_MASK); | ||
| robot.delay(150); | ||
| } | ||
|
|
||
| robot.waitForIdle(); | ||
| robot.delay(250); | ||
|
|
||
| if (eventsList.size() != INCREMENTS_COUNT) { | ||
| throw new RuntimeException("Wrong number of events: " + eventsList.size()); | ||
| } | ||
|
|
||
| int oldValue = 0; | ||
| for (AdjustmentEvent event : eventsList) { | ||
| System.out.println("\nChecking event " + event); | ||
|
|
||
| int diff = event.getValue() - oldValue; | ||
| System.out.printf("diff: %d - %d = %d\n", event.getValue(), oldValue, diff); | ||
|
|
||
| if (diff != UNIT_INCREMENT_VALUE) { | ||
| throw new RuntimeException("Unexpected adjustment value: %d".formatted(diff)); | ||
| } | ||
|
|
||
| oldValue = event.getValue(); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the original issue title.