8354084: Streamline XPath API's extension function control

[JoeWang-Java]

Streamline the extension function control in the XPath API by relying solely on XPathFunctionResolver, which provides a secure and developer-defined mechanism. Remove the feature FEATURE_SECURE_PROCESSING and jdk.xml.enableExtensionFunctions from the decision path that are redundant with regard to XPath's Extension Functions.

Note the comment in JAXPExtensionsProvider, starting at "JAXP 1.3 spec says When ...", was not accurate. Refer to the spec: https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/XMLConstants.html#FEATURE_SECURE_PROCESSING, FSP does not have specific requirement for the XPath functions.

Tests:
Tier1 - 3 passed with regard to this change. There were unrelated/known failures (e.g. bug8329757).
JCK passed except the previously reported issue (JCK-7322355).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8354085 to be approved
• Commit message must refer to an issue

Issues

• JDK-8354084: Streamline XPath API's extension function control (Enhancement - P4)
• JDK-8354085: Streamline XPath API's extension function control (CSR)

Reviewers

• Naoto Sato (@naotoj - Reviewer) Review applies to c7ec55a1
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24605/head:pull/24605
$ git checkout pull/24605

Update a local copy of the PR:
$ git checkout pull/24605
$ git pull https://git.openjdk.org/jdk.git pull/24605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24605

View PR using the GUI difftool:
$ git pr show -t 24605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24605.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354084: Streamline XPath API's extension function control

Reviewed-by: rriggs, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• e020752: 8354484: SIGSEGV when supertype of an AOT-cached class is excluded
• 594b265: 8350126: Regression ~3% on Crypto-ChaCha20Poly1305.encrypt for MacOSX aarch64
• d783a94: 8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int'
• ... and 89 more: https://git.openjdk.org/jdk/compare/84458ec18ce33295636f7b26b8e3ff25ecb349f2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@JoeWang-Java The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (8359153c)
• 03: Full - Incremental (4f26a489)
• 02: Full - Incremental (c7ec55a1)
• 01: Full - Incremental (72c138f0)
• 00: Full (f27712fc)

[naotoj]

LGTM

[RogerRiggs]

The additional confirming text in the CSR is not present above.

[JoeWang-Java]

Thanks Roger. Updated the description for the jdk.xml.enableExtensionFunctions property and fixed the default value (missing from the JDK-8343001 patch).

[RogerRiggs]

look fine. Thanks

[JoeWang-Java]

/integrate

[openjdk]

Going to push as commit cf0db96.
Since your change was applied there have been 266 commits pushed to the master branch:

• 6b553ac: 8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused
• 09cae5f: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows
• 2ad639f: 8356021: Use Double::hashCode in java.util.Locale::hashCode
• ... and 263 more: https://git.openjdk.org/jdk/compare/84458ec18ce33295636f7b26b8e3ff25ecb349f2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JoeWang-Java Pushed as commit cf0db96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.