8354510: Skipped gtest cause test failure

[xmas92]

GTEST_SKIPPED tests count is accounted in gtests run. But when we calculate the number of GTEST errors we take ERROR = RUN - PASSED - FAILED. We need parse and account for the skipped as well. Currently we only account for DISABLED gtests (which are not counted as run tests).

This patch adds support for both DISABLED and GTEST_SKIPPED tests.

So with this patch we end up with:
ERROR = RUN - PASSED - FAILED - GTEST_SKIPPED
SKIPPED = GTEST_SKIPPED + GTEST_DISABLED

Verified that this works locally on MacOS and Linux. Currently running through testing and GHA.

The old match expression was problematic with some awk, not sure if there was some other reason it was used, rather than the style used elsewhere maybe set, if unset set=0

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354510: Skipped gtest cause test failure (Bug - P4)

Reviewers

• Robbin Ehn (@robehn - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24622/head:pull/24622
$ git checkout pull/24622

Update a local copy of the PR:
$ git checkout pull/24622
$ git pull https://git.openjdk.org/jdk.git pull/24622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24622

View PR using the GUI difftool:
$ git pr show -t 24622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24622.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354510: Skipped gtest cause test failure

Reviewed-by: rehn, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 97e1075: 8354358: ZGC: ZPartition::prime handle discontiguous reservations correctly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2c2977ff)

[robehn]

Works fine at my end, looks fine, thank you!

[xmas92]

Thanks for the review
/integrate

[openjdk]

Going to push as commit 76ff978.
Since your change was applied there have been 14 commits pushed to the master branch:

• c7b70a1: 8354111: JavaDoc states that Iterator.remove() is linear in the LinkedBlockingDeque
• 92e52fe: 8353946: Incorrect WINDOWS ifdef in os::build_agent_function_name
• 5280b7b: 8353592: Open source several scrollbar tests
• ... and 11 more: https://git.openjdk.org/jdk/compare/51ce312001f3974a7e6394e9c616b04d8fb811ec...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 76ff978.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.