8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2"

[JohnTortugo]

Please, review this trivial PR to set more meaningful names for get_vm_result*.

I tested the best I could on OSX AArch64 & Linux amd64 with JTREG tier1-3.
The other platforms I tested by cross-compiling. If you can run some tests on those platform I'd appreciate.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2" (Task - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer) Review applies to ce19dd8d
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24632/head:pull/24632
$ git checkout pull/24632

Update a local copy of the PR:
$ git checkout pull/24632
$ git pull https://git.openjdk.org/jdk.git pull/24632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24632

View PR using the GUI difftool:
$ git pr show -t 24632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24632.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JohnTortugo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2"

Reviewed-by: shade, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• a2d7f44: 8295651: JFR: 'jfr scrub' should summarize what was removed
• 0c34bf0: 8354471: Assertion failure with -XX:-EnableX86ECoreOpts
• 98dac46: 8353589: Open source a few Swing menu-related tests
• ... and 45 more: https://git.openjdk.org/jdk/compare/0da480a91d31ee8dc2532cfec76bbf5b1d6c4eeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@JohnTortugo this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout vm-result-renaming
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@JohnTortugo The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (1333e4a0)
• 01: Full (ce19dd8d)
• 00: Full (470ac82c)

[coleenp]

I like this change. vm_result_2 for metadata result was never a good name.

[shipilev]

I like this. Some stylistic nits:

[shipilev]

Suggested change

	void set_vm_result_oop(oop x) { _vm_result_oop = x; }
	void set_vm_result_oop(oop x) { _vm_result_oop = x; }

[coleenp]

I don't think John fixed the space here.

[shipilev]

Right. But whatever, I won't quibble. @JohnTortugo -- fix it if you can.

[shipilev]

Looks good!

[JohnTortugo]

/integrate

[openjdk]

@JohnTortugo
Your change (at version 1333e4a) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 055b750.
Since your change was applied there have been 51 commits pushed to the master branch:

• a71f621: 8353694: Resolved Class/Field/Method CP entries missing from AOT Configuration
• 07aad68: 8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction
• db2dffb: 8354559: gc/g1/TestAllocationFailure.java doesn't need WB API
• ... and 48 more: https://git.openjdk.org/jdk/compare/0da480a91d31ee8dc2532cfec76bbf5b1d6c4eeb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @JohnTortugo Pushed as commit 055b750.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.