8354544: Fix bugs in increment and xor APX codegen #24637

vamsi-parasa · 2025-04-14T23:25:14Z

This PR fixes the bugs discovered in the APX NDD code generation PR (#23501) that got integrated into OpenJDK.

The following compiler tests uncovered these bugs:

test/hotspot/jtreg/compiler/c2/cr6340864/TestLongVect.java
test/hotspot/jtreg/compiler/c2/cr7192963/TestLongVect.java
test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java
test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java

After the bug fixes in this PR, using Intel Software Development Emulator (SDE) it was verified that the above tests are working correctly when using Intel APX.

Below is a representative error for the TEST: compiler/c2/cr6340864/TestLongVect.java
STDERR:
test_xorc: [0] = 9223372032566684971 != -7818520746908513990
test_xorc: [1] = 9223372032566684972 != -7818520746908513987
test_xorc: [994] = -9223372032566684979 != 7818520746908514012
test_xorc: [995] = -9223372032566684978 != 7818520746908514015
test_xorc: [996] = -9223372032566684977 != 7818520746908514014
test_xorv: [0] = 9223372032566684971 != -7818520746908513990
test_xorv: [1] = 9223372032566684972 != -7818520746908513987
test_xorv: [994] = -9223372032566684979 != 7818520746908514012
test_xorv: [995] = -9223372032566684978 != 7818520746908514015
test_xorv: [996] = -9223372032566684977 != 7818520746908514014
test_xora: [0] = 9223372032566684971 != -7818520746908513990
test_xora: [1] = 9223372032566684972 != -7818520746908513987
test_xora: [2] = 9223372032566684973 != -7818520746908513988
test_xora: [3] = 9223372032566684974 != -7818520746908513985
test_xora: [4] = 9223372032566684975 != -7818520746908513986
FAILED: 15 errors
TEST RESULT: Failed. Execution failed: Execution failed

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8354544: Fix bugs in increment and xor APX codegen (Bug - P3)

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer)
Jatin Bhateja (@jatin-bhateja - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24637/head:pull/24637
$ git checkout pull/24637

Update a local copy of the PR:
$ git checkout pull/24637
$ git pull https://git.openjdk.org/jdk.git pull/24637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24637

View PR using the GUI difftool:
$ git pr show -t 24637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24637.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-14T23:25:44Z

👋 Welcome back sparasa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-14T23:25:54Z

@vamsi-parasa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354544: Fix bugs in increment and xor APX codegen

Reviewed-by: thartmann, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 207 new commits pushed to the master branch:

4e3f184: 8353000: Open source several swing tests batch2
cec48ed: 8354542: Clean up x86 stubs after 32-bit x86 removal
fc14647: 8354320: Changes to jpackage.md cause pandoc warning
... and 204 more: https://git.openjdk.org/jdk/compare/57df89c46449a19bb626fee2ea01c868e6dfb712...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-04-14T23:26:44Z

@vamsi-parasa The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-14T23:33:25Z

Webrevs

01: Full - Incremental (b1a47149)
00: Full (83832b88)

openjdk · 2025-04-14T23:52:09Z

⚠️ @vamsi-parasa This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

TobiHartmann

That looks good to me.

I converted the sub-task to a bug. Please use a more descriptive title and add the failure modes to the description of the JBS issue. Thanks!

jatin-bhateja

Looks good to me.

Best Regards,
Jatin

vamsi-parasa · 2025-04-15T21:09:52Z

That looks good to me.

I converted the sub-task to a bug. Please use a more descriptive title and add the failure modes to the description of the JBS issue. Thanks!

Hi Tobias (@TobiHartmann),
Thank you for the suggestions and approval! The title and description for the JBS entry and this PR were updated to show a representative failure mode.

Thanks,
Vamsi

vamsi-parasa · 2025-04-15T21:10:38Z

Looks good to me.

Best Regards, Jatin

Thank You Jatin for approving the PR!

Regards,
Vamsi

vamsi-parasa · 2025-04-15T21:10:58Z

/integrate

openjdk · 2025-04-15T21:12:03Z

@vamsi-parasa
Your change (at version b1a4714) is now ready to be sponsored by a Committer.

sviswa7 · 2025-04-15T21:23:47Z

/sponsor

openjdk · 2025-04-15T21:25:09Z

Going to push as commit 513c465.
Since your change was applied there have been 207 commits pushed to the master branch:

4e3f184: 8353000: Open source several swing tests batch2
cec48ed: 8354542: Clean up x86 stubs after 32-bit x86 removal
fc14647: 8354320: Changes to jpackage.md cause pandoc warning
... and 204 more: https://git.openjdk.org/jdk/compare/57df89c46449a19bb626fee2ea01c868e6dfb712...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-15T21:25:24Z

@sviswa7 @vamsi-parasa Pushed as commit 513c465.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8329030: Fix bugs in APX NDD code generation for OpenJDK PR

83832b8

openjdk bot added the rfr Pull request is ready for review label Apr 14, 2025

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 14, 2025

vamsi-parasa changed the title ~~8329030: Fix bugs in APX NDD code generation for OpenJDK PR~~ 8354544: Fix bugs in APX NDD code generation for OpenJDK PR Apr 14, 2025

vamsi-parasa added 2 commits April 14, 2025 16:49

8354544: Fix bugs in APX NDD code generation for OpenJDK PR

5d3c088

Merge branch 'apxfix' of https://github.com/vamsi-parasa/jdk into apxfix

b1a4714

TobiHartmann approved these changes Apr 15, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2025

jatin-bhateja approved these changes Apr 15, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 15, 2025

vamsi-parasa changed the title ~~8354544: Fix bugs in APX NDD code generation for OpenJDK PR~~ 8354544: Fix bugs in increment and xor APX codegen Apr 15, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 15, 2025

openjdk bot closed this Apr 15, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 15, 2025

8354544: Fix bugs in increment and xor APX codegen #24637

8354544: Fix bugs in increment and xor APX codegen #24637

Uh oh!

Conversation

vamsi-parasa commented Apr 14, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 14, 2025

Uh oh!

openjdk bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 14, 2025

Uh oh!

mlbridge bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Apr 14, 2025

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

jatin-bhateja left a comment

Choose a reason for hiding this comment

Uh oh!

vamsi-parasa commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vamsi-parasa commented Apr 15, 2025

Uh oh!

vamsi-parasa commented Apr 15, 2025

Uh oh!

openjdk bot commented Apr 15, 2025

Uh oh!

sviswa7 commented Apr 15, 2025

Uh oh!

openjdk bot commented Apr 15, 2025

Uh oh!

openjdk bot commented Apr 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

vamsi-parasa commented Apr 14, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 14, 2025 •

edited

Loading

mlbridge bot commented Apr 14, 2025 •

edited

Loading

vamsi-parasa commented Apr 15, 2025 •

edited

Loading