Skip to content

Conversation

@honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Apr 14, 2025

Following tests are updates as part of this PR:

  1. javax/swing/JRootPane/bug4614623.java - manual
  2. javax/swing/JTabbedPane/bug4613811.java - manual
  3. javax/swing/JWindow/bug4251781.java - manual
  4. javax/swing/JFrame/bug4419914.java - manual, updated existing test by adding JWindow, JDialog cases.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353319: Open source Swing tests - Set 3 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24639/head:pull/24639
$ git checkout pull/24639

Update a local copy of the PR:
$ git checkout pull/24639
$ git pull https://git.openjdk.org/jdk.git pull/24639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24639

View PR using the GUI difftool:
$ git pr show -t 24639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24639.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353319: Open source Swing tests - Set 3

Reviewed-by: abhiscxk, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 15, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

Webrevs

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some minor observation.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 17, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

Going to push as commit bf63f9f.
Since your change was applied there have been 155 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2025
@openjdk openjdk bot closed this Apr 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@honkar-jdk Pushed as commit bf63f9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants