-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
The fix looks ok to me. Just an interesting note that this test took such a long time to run. Given the amount of locales, limit(30) would reduce the time to approximately 1/5 of the time, that would still be about 100,000ms according to the bug report. That feels pretty long for a single test case that, outside of the test environment, takes only 1s (my local test took 5s without limit(30)). Also, there are a bunch of other tests that also run through all of the available locales, I wonder if they also take a long time to run. |
As of JDK15, there are more than 800 locales, so reducing the samples down to 30 makes it less than 4% of the original (~20,000ms on that machine). But I agree that the test took too long than my environment too. Could be a very slow machine. |
I see. I didn't know locales had gone from 160 to 800! All the more reason to set a limit. Rerun with jdk 16, limit(30) does make it a breeze comparing to that without (which made my machine start to spin). 20,000ms is reasonable on a slower machine with a debug build. |
/integrate |
@naotoj Since your change was applied there have been 19 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit becee64. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this simple test case fix. By sampling locales to test, it reduces the possibility of the time out.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2465/head:pull/2465
$ git checkout pull/2465