8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources

[alexeysemenyukoracle]

Remove needless #ifdef __cplusplus from .cpp sources

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources

Reviewers

• Andy Herrick (@andyherrick - Reviewer) ⚠️ Review applies to e924131986aaa60ed5569eabe045476b58e4e765
• Alexander Matveev (@sashamatveev - Committer) ⚠️ Review applies to e924131986aaa60ed5569eabe045476b58e4e765
• Ioi Lam (@iklam - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2466/head:pull/2466
$ git checkout pull/2466

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bd1c3af)
• 00: Full (e924131986aaa60ed5569eabe045476b58e4e765)

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources

Reviewed-by: herrick, almatvee, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• edd5fc8: 8261096: Convert jlink tool to use Stream.toList()
• 2f893c2: 8260337: Optimize ImageReader lookup, used by Class.getResource
• f0bd9db: 8257569: Failure observed with JfrVirtualMemory::initialize
• 906faca: 8260372: [PPC64] Add support for JDK-8210498 and JDK-8222841
• b38d5be: 8261340: Fix 'deprecated' warnings in the vmTestbase/nsk tests
• b0e7e5a: 8261263: Simplify javadoc link code
• 8ebed28: 8261237: remove isClassPathAttributePresent method
• 5183d8a: 8260355: AArch64: deoptimization stub should save vector registers
• 5d8204b: 8261368: The new TestNullSetColor test is placed in the wrong group
• f03e839: 8261127: Cleanup THREAD/TRAPS/CHECK usage in CDS code
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/48c932e1f1e5a79a28211f72dc9f10d8fd30b955...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

The Bug Synopsis of 'Consider rewriting in C++ or moving to ".c" files' is unclear.
I would request that the Bug Synopsis to be changed to "removed unnecessary #ifdef __cplusplus" before integrating this PR.

[alexeysemenyukoracle]

The Bug Synopsis of 'Consider rewriting in C++ or moving to ".c" files' is unclear.
I would request that the Bug Synopsis to be changed to "removed unnecessary #ifdef __cplusplus" before integrating this PR.

Bug Synopsis updated as suggested.

[kevinrushforth]

@alexeysemenyukoracle FYI, there was no need to force-push (or even push at all) to your branch. It doesn't matter at all what the commit message(s) of the commit(s) in the source branch are. Skara will use the title of the PR, which needs to match the JBS bug, as the final commit message.

[alexeysemenyukoracle]

@alexeysemenyukoracle FYI, there was no need to force-push (or even push at all) to your branch. It doesn't matter at all what the commit message(s) of the commit(s) in the source branch are. Skara will use the title of the PR, which needs to match the JBS bug, as the final commit message.

Thank you! I was wondering how it picks up a message for squashed commit that goes in open jdk repo. Now I know.

[alexeysemenyukoracle]

/integrate

[openjdk]

@alexeysemenyukoracle Since your change was applied there have been 28 commits pushed to the master branch:

• 05c6009: 8259656: fixpath.sh changes broke _NT_SYMBOL_PATH in RunTests.gmk
• ef7ee3f: 8225081: Remove Telia Company CA certificate expiring in April 2021
• 7c565f8: 8261209: isStandalone property: remove dependency on pretty-print
• 01d9280: 8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath
• a00b130: 8261356: Clean up enum G1Mark
• becee64: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out
• f395ee0: 8261306: ServiceLoader documentation has malformed Unicode escape
• 8f4c15f: 8198540: Dynalink leaks memory when generating type converters
• edd5fc8: 8261096: Convert jlink tool to use Stream.toList()
• 2f893c2: 8260337: Optimize ImageReader lookup, used by Class.getResource
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/48c932e1f1e5a79a28211f72dc9f10d8fd30b955...master

Your commit was automatically rebased without conflicts.

Pushed as commit 699a3cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.