8354629: Test tools/jlink/ClassFileInMetaInfo.java fails on builds with configure option --enable-linkable-runtime

[jerboaa]

Please review this trivial test-only fix. A new test introduced with JDK-8353267 runs jlink using the ToolProvider API in-process. This is problematic for JEP 493 enabled builds which don't allow to be run on a patched JDK. Note that JTREG patches the JDK's java.base module with JTRegModuleHelper class. The fix is to run in othervm instead.

Testing:

• GHA
• jlink tests on a build with --enable-linkable-runtime. Shows the failure before and passes after.

Thoughts?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354629: Test tools/jlink/ClassFileInMetaInfo.java fails on builds with configure option --enable-linkable-runtime (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24661/head:pull/24661
$ git checkout pull/24661

Update a local copy of the PR:
$ git checkout pull/24661
$ git pull https://git.openjdk.org/jdk.git pull/24661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24661

View PR using the GUI difftool:
$ git pr show -t 24661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24661.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354629: Test tools/jlink/ClassFileInMetaInfo.java fails on builds with configure option --enable-linkable-runtime

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• cec48ed: 8354542: Clean up x86 stubs after 32-bit x86 removal
• fc14647: 8354320: Changes to jpackage.md cause pandoc warning

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jerboaa The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fbed6964)

[AlanBateman]

okay

[jerboaa]

/integrate

[openjdk]

Going to push as commit 18d605f.
Since your change was applied there have been 9 commits pushed to the master branch:

• 9a5c7b3: 8351162: Clean up x86 (Macro)Assembler after 32-bit x86 removal
• 2be5bc8: 8354214: Open source Swing tests Batch 2
• 55afcb5: 8352682: Opensource JComponent tests
• ... and 6 more: https://git.openjdk.org/jdk/compare/36864a2a08b5b64e63a9265d595ba7fb608994cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 18d605f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.