8295651: JFR: 'jfr scrub' should summarize what was removed

[egahlin]

Could I have a review of an enhancement that summarizes the results of jfr scrub?

To accommodate this feature, I made some additional changes:

• Added a LongMap::values() method.
• Added a Command::printf(...) method, which is now also used by jfr summary.
• Improved TestScrub.java so it now creates a file that spans multiple chunks, including an empty one.

To make it easier to locate the scrubbed file, I also changed so the real path instead of the of the absolute path is displayed in the summary

See issue for example output.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295651: JFR: 'jfr scrub' should summarize what was removed (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24669/head:pull/24669
$ git checkout pull/24669

Update a local copy of the PR:
$ git checkout pull/24669
$ git pull https://git.openjdk.org/jdk.git pull/24669/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24669

View PR using the GUI difftool:
$ git pr show -t 24669

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24669.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295651: JFR: 'jfr scrub' should summarize what was removed

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 1ad869f: 8322706: AnnotationTypeMismatchException in javac with annotation processing
• 7ffad35: 8352568: Test gtest/AsyncLogGtest.java failed at droppingMessage_vm
• c6243fc: Merge
• ... and 20 more: https://git.openjdk.org/jdk/compare/36864a2a08b5b64e63a9265d595ba7fb608994cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (90c8a753)

[mgronlun]

Brilliant change. Thank you for doing it.

[egahlin]

/integrate

[openjdk]

Going to push as commit a2d7f44.
Since your change was applied there have been 31 commits pushed to the master branch:

• 0c34bf0: 8354471: Assertion failure with -XX:-EnableX86ECoreOpts
• 98dac46: 8353589: Open source a few Swing menu-related tests
• e433fa2: 8352001: AOT cache should not contain classes injected into built-in class loaders
• ... and 28 more: https://git.openjdk.org/jdk/compare/36864a2a08b5b64e63a9265d595ba7fb608994cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit a2d7f44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.