Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261306: ServiceLoader documentation has malformed Unicode escape #2468

Closed
wants to merge 1 commit into from

Conversation

@bplb
Copy link
Member

@bplb bplb commented Feb 9, 2021

Please review this really small correction to the class level documentation of java.util.ServiceLoader.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261306: ServiceLoader documentation has malformed Unicode escape

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2468/head:pull/2468
$ git checkout pull/2468

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 9, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Feb 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 9, 2021

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

I think this is fine. You could also probably use &num given this is HTML I believe

@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261306: ServiceLoader documentation has malformed Unicode escape

Reviewed-by: lancea, iris, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5d8204b: 8261368: The new TestNullSetColor test is placed in the wrong group
  • f03e839: 8261127: Cleanup THREAD/TRAPS/CHECK usage in CDS code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 9, 2021
naotoj
naotoj approved these changes Feb 9, 2021
@bplb
Copy link
Member Author

@bplb bplb commented Feb 9, 2021

/integrate

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@bplb Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f395ee0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the 8261306-ServiceLoader-comment branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants