8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6

[david-beaumont]

Increasing timeout for deadlock detection and adjusting for the timeout factor in higher tiers.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6 (Bug - P3)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Stuart Marks (@stuart-marks - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24687/head:pull/24687
$ git checkout pull/24687

Update a local copy of the PR:
$ git checkout pull/24687
$ git pull https://git.openjdk.org/jdk.git pull/24687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24687

View PR using the GUI difftool:
$ git pr show -t 24687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24687.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@david-beaumont This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6

Reviewed-by: dfuchs, smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 171 new commits pushed to the master branch:

• 370e611: 8355221: Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests
• 29f1070: 8355211: nsk/jdi/EventRequest/disable/disable001.java should use JDIBase superclass
• 862797f: 8355293: [TEST] RISC-V: enable more ir tests
• ... and 168 more: https://git.openjdk.org/jdk/compare/fe3bd5d62fdedb7890bd3d589b04285be79c24ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @stuart-marks) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@david-beaumont The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3a28b4fe)
• 00: Full (7dbb696c)

[dfuch]

Hard to tell whether 1s would be enough. I'd be tempted to bump that up.
You should also take the test out of the problem list.

[dfuch]

The proposed changes look good to me.

[stuart-marks]

Looks reasonable. This raises the base timeout by 4x. It also includes the timeout factor adjustment, which can be quite large (8x?) in higher tiers. I think at this point we just have to expose it to more runs to see whether it still fails too frequently.

[david-beaumont]

/integrate

[openjdk]

@david-beaumont
Your change (at version 3a28b4f) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit e01e33d.
Since your change was applied there have been 171 commits pushed to the master branch:

• 370e611: 8355221: Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests
• 29f1070: 8355211: nsk/jdi/EventRequest/disable/disable001.java should use JDIBase superclass
• 862797f: 8355293: [TEST] RISC-V: enable more ir tests
• ... and 168 more: https://git.openjdk.org/jdk/compare/fe3bd5d62fdedb7890bd3d589b04285be79c24ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @david-beaumont Pushed as commit e01e33d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.