8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK

[jianglizhou]

Please review this simple test change that skips the test case loading using JDK libzip.so on static JDK in test/jdk/jdk/internal/loader/NativeLibraries/Main.java. AFAICT, the test case using NativeLibrariesTest.LIB_NAME (libnativeLibrariesTest.so) can provide coverage on static JDK.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24704/head:pull/24704
$ git checkout pull/24704

Update a local copy of the PR:
$ git checkout pull/24704
$ git pull https://git.openjdk.org/jdk.git pull/24704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24704

View PR using the GUI difftool:
$ git pr show -t 24704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24704.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 5392488: 8355332: Fix failing semi-manual test EDT issue
• b7e8952: 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication
• cc9148d: 8354695: Open source several swing tests batch7
• ... and 91 more: https://git.openjdk.org/jdk/compare/a2d7f441b8616e0cd8c231f3358b1b508e76686d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jianglizhou The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (225d43fd)

[sendaoYan]

Hi, the other tests which also call NativeLibrariesTest.load(String, boolean), does the other tests also need this check !Platform.isStatic()

[jianglizhou]

@sendaoYan, NativeLibrariesTest is only used by test/jdk/jdk/internal/loader/NativeLibraries/Main.java.

[jaikiran]

Hello Jiangli, can you add a few more details to the linked JBS issue? If I understand this change correctly, then what's being proposed in this PR seems to indicate that the jdk.internal.loader.RawNativeLibraries is unable to load libzip whose Path is determined by a call to the System.mapLibraryName(...) standard API. I don't currently have access to a static JDK. Can you include the Path that's returned for System.mapLibraryName("zip") on a static JDK?

[jianglizhou]

Hello Jiangli, can you add a few more details to the linked JBS issue? If I understand this change correctly, then what's being proposed in this PR seems to indicate that the jdk.internal.loader.RawNativeLibraries is unable to load libzip whose Path is determined by a call to the System.mapLibraryName(...) standard API. I don't currently have access to a static JDK. Can you include the Path that's returned for System.mapLibraryName("zip") on a static JDK?

@jaikiran Added details in https://bugs.openjdk.org/browse/JDK-8354898, thanks for the suggestion. I also added command line examples for building static-jdk and the current method for running jtreg tests on static-jdk.

[jaikiran]

Thank you Jiangli for the details in the JBS issue. That helped. Having read the documentation of jdk.internal.loader.RawNativeLibraries yesterday:

 * RawNativeLibraries has the following properties:
 * 1. Native libraries loaded in this RawNativeLibraries instance are
 *    not JNI native libraries.  Hence JNI_OnLoad and JNI_OnUnload will
 *    be ignored.  No support for linking of native method.

I mistook that it cannot be used to load JNI libraries and that's what confused me about this test since libzip is a JNI library. But reading this text again, I now realize that it can be used to load a JNI native library, but the loaded library won't be treated as a JNI library by RawNativeLibraries. So the usage of libzip in that test seems OK. I further looked at the change which introduced this usage in that test to understand if it was intentional to use a JNI library here. It appears that it was introduced in https://bugs.openjdk.org/browse/JDK-8281335 and so was an intentional decision to use a JNI library.

Given all this, I think the proposal to skip this loading for static JDK seems reasonable to me.

[jaikiran]

I also added command line examples for building static-jdk and the current method for running jtreg tests on static-jdk.

Thank you, that will help me in future.

[jianglizhou]

@jaikiran Thank's a lot for the careful review!

[jianglizhou]

/integrate

[openjdk]

Going to push as commit 12c3a23.
Since your change was applied there have been 112 commits pushed to the master branch:

• 6befc18: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test
• 023f30b: 8355394: ZGC: Windows compile error in ZUtils
• e8a1a64: 8355401: Remove unused HWperKB
• ... and 109 more: https://git.openjdk.org/jdk/compare/a2d7f441b8616e0cd8c231f3358b1b508e76686d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jianglizhou Pushed as commit 12c3a23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.