Skip to content

8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK #24704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jianglizhou wants to merge 1 commit into from
Closed

8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK #24704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/jdk/jdk/internal/loader/NativeLibraries/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -24,13 +24,15 @@
/*
* @test
* @bug 8240975 8281335
* @library /test/lib
* @modules java.base/jdk.internal.loader
* @build java.base/* p.Test Main
* @run main/othervm/native -Xcheck:jni Main
* @summary Test loading and unloading of native libraries
*/

import jdk.internal.loader.NativeLibrariesTest;
import jdk.test.lib.Platform;

import java.io.IOException;
import java.nio.file.Files;
Expand All @@ -55,7 +57,9 @@ public static void main(String... args) throws Exception {
test.unload();

// load zip library from JDK
test.load(System.mapLibraryName("zip"), true /* succeed */);
if (!Platform.isStatic()) {
test.load(System.mapLibraryName("zip"), true /* succeed */);
Copy link
Member

@sendaoYan sendaoYan Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the other tests which also call NativeLibrariesTest.load(String, boolean), does the other tests also need this check !Platform.isStatic()

Copy link
Contributor Author

@jianglizhou jianglizhou Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan, NativeLibrariesTest is only used by test/jdk/jdk/internal/loader/NativeLibraries/Main.java.

}

// load non-existent library
test.load(System.mapLibraryName("NotExist"), false /* fail to load */);
Expand Down