8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction #24709

Anjian-Wen · 2025-04-17T03:01:42Z

support zvbb vand-not vector-scalar version, which Op1 is the sign-extended or truncated value in scalar register rs1
add C2 match rule
add related Tests in IRNode structure

passed jtreg test test/hotspot/jtreg/compiler/vectorapi/*

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction (Enhancement - P4)

Reviewers

Feilong Jiang (@feilongjiang - Committer)
Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24709/head:pull/24709
$ git checkout pull/24709

Update a local copy of the PR:
$ git checkout pull/24709
$ git pull https://git.openjdk.org/jdk.git pull/24709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24709

View PR using the GUI difftool:
$ git pr show -t 24709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24709.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-17T03:02:20Z

👋 Welcome back Anjian-Wen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-17T03:02:51Z

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

f66b9ba: 8346785: Potential infinite loop in JavadocTokenizer.ensures
89f9268: 8355524: Only every second line in upgradeable files is being used
b41e0b1: 8355387: [jittester] Disable downcasts by default
... and 3 more: https://git.openjdk.org/jdk/compare/ed604038ffc4ca64113984324dde71c07f046b52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@feilongjiang, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-04-17T03:03:30Z

@Anjian-Wen The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2025-04-18T11:41:06Z

@Anjian-Wen this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout Vector_And-Not_vx
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Support Zvbb Vector And-Not vx and add its tests modify name of the match rule and test name

Anjian-Wen · 2025-04-21T02:25:31Z

/issue JDK-8355074

openjdk · 2025-04-21T02:25:51Z

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

change some '_imm' to '_vi'

mlbridge · 2025-04-24T05:58:25Z

Webrevs

RealFYang · 2025-04-24T11:37:37Z

test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java

        machOnlyNameRegex(VAND_NOT_L_MASKED, "vand_notL_masked");
    }

+    public static final String VAND_NOTI_VX = PREFIX + "VAND_NOTI_VX" + POSTFIX;


Since this is a shared file and these four instructions are RISCV-specific, seems better to add a RISCV_ prefix to make that explicit. Consider names like RISCV_VAND_NOTI_VX, RISCV_VAND_NOTL_VX, RISCV_VAND_NOTI_VX_MASKED and RISCV_VAND_NOTL_VX_MASKED.

feilongjiang

Thanks! Overall looks good, with one minor suggestion.

feilongjiang · 2025-04-24T14:22:34Z

src/hotspot/cpu/riscv/riscv_v.ad

 // vector-immediate add (unpredicated)

-instruct vadd_immI(vReg dst, vReg src1, immI5 con) %{
+instruct vaddI_vi(vReg dst, vReg src1, immI5 con) %{


Perhaps we can do these naming refactorings in a separate PR first. This will look cleaner.

thanks, that's a good idea, I'll split it into two patch

Anjian-Wen · 2025-04-25T02:21:27Z

here is the another related pr for clean up
#24865

RealFYang

Updated change looks fine. Thanks.

Anjian-Wen · 2025-04-25T10:48:44Z

/integrate

openjdk · 2025-04-25T10:49:43Z

@Anjian-Wen
Your change (at version a99d32a) is now ready to be sponsored by a Committer.

RealFYang · 2025-04-25T12:49:00Z

/sponsor

openjdk · 2025-04-25T12:50:15Z

Going to push as commit 5c06723.
Since your change was applied there have been 8 commits pushed to the master branch:

a2f9c24: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java
e6cea40: 8355475: UNCTest should use an existing UNC path
f66b9ba: 8346785: Potential infinite loop in JavadocTokenizer.ensures
... and 5 more: https://git.openjdk.org/jdk/compare/ed604038ffc4ca64113984324dde71c07f046b52...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-25T12:50:24Z

@RealFYang @Anjian-Wen Pushed as commit 5c06723.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 17, 2025

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 18, 2025

RISC-V: Support Zvbb Vector And-Not vx and add its tests

5617982

Support Zvbb Vector And-Not vx and add its tests modify name of the match rule and test name

Anjian-Wen force-pushed the Vector_And-Not_vx branch from ae63f14 to 5617982 Compare April 18, 2025 12:05

openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Apr 18, 2025

openjdk bot changed the title ~~RISC-V: Support Zvbb Vector And-Not vx and add its tests~~ 8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction Apr 21, 2025

Anjian-Wen added 3 commits April 21, 2025 11:11

add format fix

9e19eb1

modify v0.t to $v0

05b31ed

modify format

7b507b8

change some '_imm' to '_vi'

Anjian-Wen marked this pull request as ready for review April 24, 2025 05:54

openjdk bot added the rfr Pull request is ready for review label Apr 24, 2025

RealFYang reviewed Apr 24, 2025

View reviewed changes

add prefix for test String

dbdf9b8

feilongjiang approved these changes Apr 24, 2025

View reviewed changes

split the patch into cleanformat and enable zvbb

f08705b

Merge branch 'openjdk:master' into Vector_And-Not_vx

a99d32a

RealFYang approved these changes Apr 25, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2025

feilongjiang approved these changes Apr 25, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 25, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 25, 2025

openjdk bot closed this Apr 25, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 25, 2025

Anjian-Wen deleted the Vector_And-Not_vx branch April 27, 2025 06:12

8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction #24709

8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction #24709

Uh oh!

Conversation

Anjian-Wen commented Apr 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 18, 2025

Uh oh!

Anjian-Wen commented Apr 21, 2025

Uh oh!

openjdk bot commented Apr 21, 2025

Uh oh!

mlbridge bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

RealFYang Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feilongjiang left a comment

Choose a reason for hiding this comment

Uh oh!

feilongjiang Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Anjian-Wen Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Anjian-Wen commented Apr 25, 2025

Uh oh!

RealFYang left a comment

Choose a reason for hiding this comment

Uh oh!

Anjian-Wen commented Apr 25, 2025

Uh oh!

openjdk bot commented Apr 25, 2025

Uh oh!

RealFYang commented Apr 25, 2025

Uh oh!

openjdk bot commented Apr 25, 2025

Uh oh!

openjdk bot commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Anjian-Wen commented Apr 17, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 17, 2025 •

edited

Loading

mlbridge bot commented Apr 24, 2025 •

edited

Loading

RealFYang Apr 24, 2025 •

edited

Loading