Skip to content

Conversation

@ferakocz
Copy link
Contributor

@ferakocz ferakocz commented Apr 17, 2025

…JDK-8349721

Trivial modifications fixing changes used during debugging and ment to (but had been forgatten to) be fixed before integration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354926: Remove remnants of debugging in the fix for JDK-8348561 and JDK-8349721 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24717/head:pull/24717
$ git checkout pull/24717

Update a local copy of the PR:
$ git checkout pull/24717
$ git pull https://git.openjdk.org/jdk.git pull/24717/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24717

View PR using the GUI difftool:
$ git pr show -t 24717

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24717.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

👋 Welcome back ferakocz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@ferakocz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354926: Remove remnants of debugging in the fix for JDK-8348561 and JDK-8349721

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5125ceb: 8349405: Redundant and confusing null checks on data from CP::resolved_klasses

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8354926: Remove remnants of debugging in the fix for JDK-8348561 and … 8354926: Remove remnants of debugging in the fix for JDK-8348561 and JDK-8349721 Apr 17, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@ferakocz The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 17, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2025

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025
@adinn
Copy link
Contributor

adinn commented Apr 17, 2025

@ferakocz Assuming the tests complete ok you can integrate and I will sponsor.

@ferakocz
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@ferakocz
Your change (at version ee6efa9) is now ready to be sponsored by a Committer.

@ferakocz
Copy link
Contributor Author

@adinn You can /sponsor now. Thanks!

@adinn
Copy link
Contributor

adinn commented Apr 17, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

Going to push as commit cd8adf1.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025
@openjdk openjdk bot closed this Apr 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@adinn @ferakocz Pushed as commit cd8adf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants