-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8354926: Remove remnants of debugging in the fix for JDK-8348561 and JDK-8349721 #24717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ferakocz! A progress list of the required criteria for merging this PR into |
|
@ferakocz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
|
@ferakocz Assuming the tests complete ok you can integrate and I will sponsor. |
|
/integrate |
|
@adinn You can /sponsor now. Thanks! |
|
/sponsor |
|
Going to push as commit cd8adf1.
Your commit was automatically rebased without conflicts. |
…JDK-8349721
Trivial modifications fixing changes used during debugging and ment to (but had been forgatten to) be fixed before integration.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24717/head:pull/24717$ git checkout pull/24717Update a local copy of the PR:
$ git checkout pull/24717$ git pull https://git.openjdk.org/jdk.git pull/24717/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24717View PR using the GUI difftool:
$ git pr show -t 24717Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24717.diff
Using Webrev
Link to Webrev Comment