8354949: JFR: Split up the EventInstrumentation class

[egahlin]

Could I have a review of a PR that cleans up the EventInstrumentation class and moves the non-modifying parts into a separate class (ClassInspector)?

I deleted the code that removes the instrumentation (buildUninstrumented), because it has never been used. If there should be a need for it in the future, it's not hard to add code that inserts empty method bodies.

Testing: tier1 + jdk/jdk/jfr/test

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354949: JFR: Split up the EventInstrumentation class (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24726/head:pull/24726
$ git checkout pull/24726

Update a local copy of the PR:
$ git checkout pull/24726
$ git pull https://git.openjdk.org/jdk.git pull/24726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24726

View PR using the GUI difftool:
$ git pr show -t 24726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24726.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354949: JFR: Split up the EventInstrumentation class

Reviewed-by: mgronlun, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• da16c83: 8354466: Open some misc Swing bugs 9
• 072b827: 8354300: Mark String.hash field @stable
• 5264d80: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key
• ... and 59 more: https://git.openjdk.org/jdk/compare/abb23828f9dc5f4cdb75d5b924dd6f45925102cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (d6de2665)
• 02: Full - Incremental (07a56859)
• 01: Full - Incremental (8ecb2732)
• 00: Full (e692363d)

[liach]

findAttribute or findAttributes can be helpful if you just want one attribute.

[egahlin]

Agree, but I like to refactor that in a later PR. That part of the code needs a complete rewrite.

[liach]

ClassFile API usages look good.

[egahlin]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit ef0cd18.
Since your change was applied there have been 87 commits pushed to the master branch:

• 82c2494: 8354228: Parallel: Set correct minimum of InitialSurvivorRatio
• e76f203: 8354309: Sort GC includes
• c2e90bc: 8355363: [BACKOUT] 8354668: Missing REX2 prefix accounting in ZGC barriers leads to incorrect encoding
• ... and 84 more: https://git.openjdk.org/jdk/compare/abb23828f9dc5f4cdb75d5b924dd6f45925102cd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit ef0cd18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.