-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8259540: MissingResourceException for key cvc-complex-type.2.4.d.1 #24747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
|
@alexeybakhtin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@alexeybakhtin The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
JoeWang-Java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a link to JDK-8355006.
|
@alexeybakhtin also, I assigned the issue to you. Thanks. |
|
Added missed localized strings for _de, _ja and _zh_CN localities based on the JDK11 localizations |
Probably not necessary as they will be covered by L10n resource update. |
|
Sorry, I didn't know about L10n resource updates. @JoeWang-Java, do you suggest removing localizations and waiting for "JDK 25 RDP1 L10n resource files update" in June? |
Yes, I would. I removed resource files other than English from my previous PR as well after getting reviewers' suggestions. |
This reverts commit 3ad1f7f.
JoeWang-Java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
|
/integrate |
|
Going to push as commit 4f58af0.
Your commit was automatically rebased without conflicts. |
|
@alexeybakhtin Pushed as commit 4f58af0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please find a trivial fix for the missing
cvc-complex-type.2.4.d.1resource in the main XMLSchemaMessages.properties file.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24747/head:pull/24747$ git checkout pull/24747Update a local copy of the PR:
$ git checkout pull/24747$ git pull https://git.openjdk.org/jdk.git pull/24747/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24747View PR using the GUI difftool:
$ git pr show -t 24747Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24747.diff
Using Webrev
Link to Webrev Comment