Skip to content

Conversation

@alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Apr 18, 2025

Please find a trivial fix for the missing cvc-complex-type.2.4.d.1 resource in the main XMLSchemaMessages.properties file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8259540: MissingResourceException for key cvc-complex-type.2.4.d.1 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24747/head:pull/24747
$ git checkout pull/24747

Update a local copy of the PR:
$ git checkout pull/24747
$ git pull https://git.openjdk.org/jdk.git pull/24747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24747

View PR using the GUI difftool:
$ git pr show -t 24747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24747.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2025

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259540: MissingResourceException for key cvc-complex-type.2.4.d.1

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@alexeybakhtin The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 18, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2025

Webrevs

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a link to JDK-8355006.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2025
@JoeWang-Java
Copy link
Member

@alexeybakhtin also, I assigned the issue to you. Thanks.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 18, 2025
@alexeybakhtin
Copy link
Contributor Author

Added missed localized strings for _de, _ja and _zh_CN localities based on the JDK11 localizations

@JoeWang-Java
Copy link
Member

Added missed localized strings for _de, _ja and _zh_CN localities based on the JDK11 localizations

Probably not necessary as they will be covered by L10n resource update.

@alexeybakhtin
Copy link
Contributor Author

Sorry, I didn't know about L10n resource updates. @JoeWang-Java, do you suggest removing localizations and waiting for "JDK 25 RDP1 L10n resource files update" in June?

@JoeWang-Java
Copy link
Member

Sorry, I didn't know about L10n resource updates. @JoeWang-Java, do you suggest removing localizations and waiting for "JDK 25 RDP1 L10n resource files update" in June?

Yes, I would. I removed resource files other than English from my previous PR as well after getting reviewers' suggestions.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2025
Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2025

Going to push as commit 4f58af0.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2025
@openjdk openjdk bot closed this Apr 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2025
@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@alexeybakhtin Pushed as commit 4f58af0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants