8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 #24753

dougxc · 2025-04-18T13:27:02Z

After JDK-8343789, the size of a JVMCINMethodData object is limited to uint16_t. This object embeds the value of InstalledCode.name so effectively imposes a limit on the name length. This PR establishes an upper limit on the name value as this name should only be for informative purposes when inspecting compiled code.

While debugging the problem that exposed the limit, it was confusing that -XX:+PrintCompilation did not show the name so this PR builds on JDK-8336760 to add the name in PrintCompilation output for JVMCI "hosted" methods.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 (Bug - P4)

Reviewers

Tom Rodriguez (@tkrodriguez - Reviewer)
Yudi Zheng (@mur47x111 - Committer) Review applies to f7c01793
Cesar Soares Lucas (@JohnTortugo - Committer) Review applies to f7c01793

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24753/head:pull/24753
$ git checkout pull/24753

Update a local copy of the PR:
$ git checkout pull/24753
$ git pull https://git.openjdk.org/jdk.git pull/24753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24753

View PR using the GUI difftool:
$ git pr show -t 24753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24753.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-18T13:27:54Z

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-18T13:28:00Z

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320

Reviewed-by: never, yzheng, cslucas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 176 new commits pushed to the master branch:

e2cb646: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main
0be3f16: 8341608: jdeps in JDK 23 crashes when parsing signatures while jdeps in JDK 22 works fine
f880fa9: 8352793: Open source several AWT TextComponent tests - Batch 1
... and 173 more: https://git.openjdk.org/jdk/compare/bcac42aabce5b57525f776037d73b51d0afcbaf5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-18T13:28:33Z

@dougxc The following labels will be automatically applied to this pull request:

graal
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

dougxc · 2025-04-18T15:18:44Z

src/hotspot/share/code/nmethod.cpp

 #define CHECKED_CAST(result, T, thing)      \
  result = static_cast<T>(thing); \
-  assert(static_cast<int>(result) == thing, "failed: %d != %d", static_cast<int>(result), thing);
+  guarantee(static_cast<int>(result) == thing, "failed: %d != %d", static_cast<int>(result), thing);


This check is not on a hot path and so can afford to be a guarantee. That said, I've no strong objection to leaving it as an assert.

dougxc · 2025-04-18T15:22:01Z

src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

+          if (name != nullptr) {
+            stringStream st;
+            st.print_cr("(hosted JVMCI compilation: %s)", name);
+            CompileTask::print(tty, nm, st.as_string());


@JohnTortugo this may be of interest to you.

mlbridge · 2025-04-18T15:26:39Z

Webrevs

openjdk · 2025-04-18T15:32:02Z

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

tkrodriguez

Looks good to me.

mur47x111

LGTM!

JohnTortugo

Thank you . LGTM

JohnTortugo · 2025-04-21T19:20:29Z

...spot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/InstalledCodeTest.java

+ */
+
+/**
+ * @test


NIT: missing JBS entry ID.

It's not clear to me how useful that is as a single test file can be for numerous bugs over time and git log will show you all of them.

That said, I've added the id as you request.

dougxc · 2025-04-22T07:06:05Z

Thanks for the reviews.

/integrate

openjdk · 2025-04-22T07:07:32Z

Going to push as commit 2f7806f.
Since your change was applied there have been 179 commits pushed to the master branch:

a55ccd2: 8352905: Open some JComboBox bugs 1
33bdc80: 8355241: Move NativeDialogToFrontBackTest.java PL test to manual category
d1d7d25: 8353957: Open source several AWT ScrollPane tests - Batch 1
... and 176 more: https://git.openjdk.org/jdk/compare/bcac42aabce5b57525f776037d73b51d0afcbaf5...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-22T07:07:46Z

@dougxc Pushed as commit 2f7806f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dougxc added 2 commits April 18, 2025 15:24

include the name if non-null when printing "hosted" JVMCI compilations

fd25160

convert assert to guarantee

c5c80e0

openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Apr 18, 2025

dougxc force-pushed the JDK-8355034 branch from dff3edd to e553eca Compare April 18, 2025 15:06

dougxc commented Apr 18, 2025

View reviewed changes

dougxc force-pushed the JDK-8355034 branch from e553eca to 03c10e9 Compare April 18, 2025 15:20

dougxc commented Apr 18, 2025

View reviewed changes

dougxc marked this pull request as ready for review April 18, 2025 15:22

openjdk bot added the rfr Pull request is ready for review label Apr 18, 2025

impose a length limit on InstalledCode.name

be003f3

dougxc force-pushed the JDK-8355034 branch from 03c10e9 to be003f3 Compare April 18, 2025 15:31

tkrodriguez approved these changes Apr 18, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2025

InstalledCode.name can be null

f7c0179

openjdk bot removed the ready Pull request is ready to be integrated label Apr 19, 2025

mur47x111 approved these changes Apr 20, 2025

View reviewed changes

JohnTortugo approved these changes Apr 21, 2025

View reviewed changes

added bug id to @test tag

2b7a07d

tkrodriguez approved these changes Apr 21, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 22, 2025

openjdk bot closed this Apr 22, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2025

dougxc mentioned this pull request Apr 25, 2025

8343789: Move mutable nmethod data out of CodeCache #21276

Closed

3 tasks

bulasevich mentioned this pull request Apr 30, 2025

8355896: Lossy narrowing cast of JVMCINMethodData::size #24965

Closed

3 tasks

+               */
+              /**
+               * @test

8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 #24753

8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 #24753

Uh oh!

Conversation

dougxc commented Apr 18, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 18, 2025

Uh oh!

openjdk bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 18, 2025

Uh oh!

dougxc Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Apr 18, 2025

Uh oh!

tkrodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

mur47x111 left a comment

Choose a reason for hiding this comment

Uh oh!

JohnTortugo left a comment

Choose a reason for hiding this comment

Uh oh!

JohnTortugo Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

dougxc Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

dougxc commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

dougxc commented Apr 18, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 18, 2025 •

edited

Loading

dougxc Apr 18, 2025 •

edited

Loading

mlbridge bot commented Apr 18, 2025 •

edited

Loading