Skip to content

8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 #24753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8355034: [JVMCI] assert(static_cast<int>(_jvmci_data_size) == align_up(compiler->is_jvmci() ? jvmci_data->size() : 0, oopSize)) failed: failed: 104 != 16777320 #24753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd25160
include the name if non-null when printing "hosted" JVMCI compilations
dougxc Apr 18, 2025
c5c80e0
convert assert to guarantee
dougxc Apr 18, 2025
be003f3
impose a length limit on InstalledCode.name
dougxc Apr 18, 2025
f7c0179
InstalledCode.name can be null
dougxc Apr 19, 2025
2b7a07d
added bug id to @test tag
dougxc Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/InstalledCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public class InstalledCode {
* @throws IllegalArgumentException if {@code name.length >} {@link #MAX_NAME_LENGTH}
*/
public InstalledCode(String name) {
if (name.length() > MAX_NAME_LENGTH) {
if (name != null && name.length() > MAX_NAME_LENGTH) {
String msg = String.format("name length (%d) is greater than %d (name[0:%s] = %s)",
name.length(), MAX_NAME_LENGTH, MAX_NAME_LENGTH, name.substring(0, MAX_NAME_LENGTH));
throw new IllegalArgumentException(msg);
Expand Down
5 changes: 5 additions & 0 deletions ...t/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/InstalledCodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@

public class InstalledCodeTest {

@Test
public void testNullName() {
new InstalledCode(null);
}

@Test
public void testTooLongName() {
String longName = new String(new char[InstalledCode.MAX_NAME_LENGTH]).replace('\0', 'A');
Expand Down