8297271: AccessFlag.maskToAccessFlags should be specific to class file version

[liach]

Take the class file version to reject flags not yet defined, redefined, or obsoleted. This is useful for clients like javap to report the correct undefined flags for different class file versions.

A preparatory patch for javap to pass around the ClassFileFormatVersion to parse flags is available at #24955.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8297741 to be approved

Issues

• JDK-8297271: AccessFlag.maskToAccessFlags should be specific to class file version (Enhancement - P3)
• JDK-8297741: AccessFlag.maskToAccessFlags should be specific to class file version (CSR)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24760/head:pull/24760
$ git checkout pull/24760

Update a local copy of the PR:
$ git checkout pull/24760
$ git pull https://git.openjdk.org/jdk.git pull/24760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24760

View PR using the GUI difftool:
$ git pr show -t 24760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24760.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into pr/23095 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297271: AccessFlag.maskToAccessFlags should be specific to class file version

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 7b31762: 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
• 0cd0afb: 8355913: RISC-V: improve hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java
• 0a697f6: 8344708: Implement JEP 511: Module Import Declarations
• ... and 3 more: https://git.openjdk.org/jdk/compare/e36756b264000fe2deb95ec8f68d1571fd7653f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full (b1cf4ebb)
• 05: Full (10be287f)
• 04: Full (41989440)
• 03: Full (47183bf2)
• 02: Full - Incremental (3db05342)
• 01: Full (e1530d7d)
• 00: Full (eb75da96)

[ExE-Boss]

With this, the Class‑File API needs to be updated to pass the current class file format version to the calls of AccessFlag​.maskToAccessFlags(…).

[liach]

That is tracked in a separate bug linked as a dependent on this issue.

[openjdk]

@liach this pull request can not be integrated into pr/23095 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout feature/af-cffv-parse
git fetch https://git.openjdk.org/jdk.git pr/23095
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/23095"
git push

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout feature/af-cffv-parse
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @liach This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[RogerRiggs]

lgtm

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout feature/af-cffv-parse
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[liach]

Did a trivial merge and reran the sanity tests for javap and AccessFlag.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit bee273d.
Since your change was applied there have been 7 commits pushed to the master branch:

• 34807df: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
• 7b31762: 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
• 0cd0afb: 8355913: RISC-V: improve hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java
• ... and 4 more: https://git.openjdk.org/jdk/compare/e36756b264000fe2deb95ec8f68d1571fd7653f9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit bee273d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.