Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Apr 19, 2025

The
CheckUnhandledOops
cause failure if JvmtiExport::post_resource_exhausted(...)
is called in
MemAllocator::Allocation::check_out_of_memory()
The obj is null so it is not a real bug.

I am fixing it to reduce noise for CheckUnhandledOops mode for jvmti tests execution.
The vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted002/TestDescription.java
failed with -XX:+CheckUnhandledOops

If define are unwelcome here, the
PreserveObj obj_h(_thread, _obj_ptr);
might be added instead with comment why it is needed for null obj.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355069: Allocation::check_out_of_memory() should support CheckUnhandledOops mode (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24766/head:pull/24766
$ git checkout pull/24766

Update a local copy of the PR:
$ git checkout pull/24766
$ git pull https://git.openjdk.org/jdk.git pull/24766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24766

View PR using the GUI difftool:
$ git pr show -t 24766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24766.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355069: Allocation::check_out_of_memory() should support CheckUnhandledOops mode

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2025
@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 19, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2025

Webrevs

@lmesnik
Copy link
Member Author

lmesnik commented Apr 19, 2025

/cc hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 19, 2025
@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@lmesnik
The hotspot-runtime label was successfully added.

@lmesnik
Copy link
Member Author

lmesnik commented Apr 21, 2025

/cc serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

@lmesnik
The serviceability label was successfully added.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 23, 2025
@lmesnik
Copy link
Member Author

lmesnik commented Apr 29, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2025

Going to push as commit 83d0bd8.
Since your change was applied there have been 191 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2025
@openjdk openjdk bot closed this Apr 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2025
@openjdk
Copy link

openjdk bot commented Apr 29, 2025

@lmesnik Pushed as commit 83d0bd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants