8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication by plummercj · Pull Request #24768 · openjdk/jdk

plummercj · 2025-04-19T05:19:22Z

Remove the need for many nsk/jdi tests to discover the main thread, resulting in the test needing to be run with includevirtualthreads=y. Details in first comment.

Tested with all tier2, tier3, and tier5 svc tests

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication (Enhancement - P3)

Reviewers

Leonid Mesnik (@lmesnik - Reviewer)
Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24768/head:pull/24768
$ git checkout pull/24768

Update a local copy of the PR:
$ git checkout pull/24768
$ git pull https://git.openjdk.org/jdk.git pull/24768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24768

View PR using the GUI difftool:
$ git pr show -t 24768

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24768.diff

Using Webrev

Link to Webrev Comment

…ding the main thread

bridgekeeper · 2025-04-19T05:19:57Z

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-19T05:20:50Z

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication

Reviewed-by: lmesnik, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

cc9148d: 8354695: Open source several swing tests batch7
1b8f760: 8354928: Clean up and open source some miscellaneous AWT tests
239760a: 8355233: Add a DMB related benchmark
... and 57 more: https://git.openjdk.org/jdk/compare/0995b9409d910d816276673b5c06fdf7826bfac7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-19T05:21:26Z

@plummercj The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

plummercj · 2025-04-19T05:21:57Z

The PR is related to JDK-8353955, which is attempting to no longer run all jdk/jdi tests with includevirtualthreads=y, allowing the default to be includevirtualthreads=n, and tests that require includevirtualthreads=y to explicitly specify that need.

The changes in this PR will reduce the number of tests that need to specify includevirtualthreads=y from about 350 to about 180. It does not make the change to have the default be includevirtualthreads=n, which will be left for JDK-8353955 once all tests are either fixed to work with includevirtualthreads=n or specify the need for includevirtualthreads=y.

The changes in this PR relate to a common pattern in the nsk/jdi tests:

    String bPointMethod = "methodForCommunication";
    String lineForComm = "lineForComm";

    ThreadReference mainThread = debuggee.threadByNameOrThrow("main");

    BreakpointRequest bpRequest = settingBreakpoint(mainThread,
                                         debuggeeClass,
                                         bPointMethod, lineForComm, "zero");

All tests that do this require includevirtualthreads=y because of the thread lookup. There is no need for mainThread in this code. null can be used instead for a global breakpoint. Once this is done, there is usually no need to run the test with includevirtualthreads=y, although in a few tests there are other calls to thread lookup API that result in the test still needing includevirtualthreads=y.

I replaced the above code with a call to a new API in JDIBase:

    setupBreakpointForCommunication(debuggeeClass);

This represents the bulk of the changes in this CR. Some tests had other references to mainThread that then needed to be addressed. For most, the thread was already stored in bpEvent and could be fetched from there:

breakpointForCommunication();
ThreadReference mainThread = bpEvent.thread(); // bpEvent saved by breakpointForCommunication()

… first round of changes.

sendaoYan

Should we update the copyright year from 2024 to 2025.

plummercj · 2025-04-19T20:27:35Z

Should we update the copyright year from 2024 to 2025.

I plan on doing that after the reviews are done. Given the large number of files being changed, I thought it would be easier to review without the noise of copyright updates in nearly every file.

mlbridge · 2025-04-21T17:01:19Z

Webrevs

lmesnik

Good to see more simplification of common code patterns.
See my small comment inline.
Also, you need to update a copyrights for changed files.

lmesnik · 2025-04-21T19:20:35Z

test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIBase.java

                    breakpRequest = eventRManager.createBreakpointRequest(lineLocation);
                    breakpRequest.putProperty("number", property);
-                    breakpRequest.addThreadFilter(thread);
+                    if (thread != null) {


The change might hide failure if thread is not set in the test.
I would prefer to have
private settingBreakpoint(ThreadReference thread,.,.) that allows null
and

protected final BreakpointRequest settingBreakpoint(ThreadReference thread, ReferenceType testedClass, String methodName, String bpLine, String property)

that still fails early if thread is null. (I think now it should fail in
breakpRequest.addThreadFilter(thread);
string.
So for any test that don't have proper thread - test fails early when setting breakpoint and not because it hasn't find it.

Ok. I updated to use a different API that implies no thread.

plummercj · 2025-04-22T23:20:35Z

Thank you for the reviews Leonid and Alex!

/integrate

openjdk · 2025-04-22T23:21:29Z

Going to push as commit b7e8952.
Since your change was applied there have been 60 commits pushed to the master branch:

cc9148d: 8354695: Open source several swing tests batch7
1b8f760: 8354928: Clean up and open source some miscellaneous AWT tests
239760a: 8355233: Add a DMB related benchmark
... and 57 more: https://git.openjdk.org/jdk/compare/0995b9409d910d816276673b5c06fdf7826bfac7...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-22T23:21:36Z

@plummercj Pushed as commit b7e8952.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

plummercj added 12 commits April 18, 2025 21:16

Cleanup methodForCommunication related code so it doesn't require fin…

e8229a7

…ding the main thread

undo minor comment change

d9f6993

undo minor comment change

fcfde41

undo minor comment change

f3d788e

undo minor comment change

3b3f306

fix whitespace error

b3a340b

get rid of debugging code

aa181dd

restore some accidentally deleted code

f40cda3

undo minor comment change

2bd065a

restore some accidentally deleted code

b18f570

undo minor comment change

e28f531

undo minor comment change

c546289

openjdk bot changed the title ~~8355071~~ 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication. Apr 19, 2025

openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 19, 2025

fix jcheck error

f724849

plummercj changed the title ~~8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication.~~ 8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication Apr 19, 2025

plummercj added 3 commits April 18, 2025 22:27

delete some lines that were relaced

1546af7

Delete some code that was suppose to have been relaced

89776f0

Use setupBreakpointForCommunication(). These files were missed on the…

934cde7

… first round of changes.

sendaoYan suggested changes Apr 19, 2025

View reviewed changes

plummercj marked this pull request as ready for review April 21, 2025 16:56

openjdk bot added the rfr Pull request is ready for review label Apr 21, 2025

lmesnik suggested changes Apr 21, 2025

View reviewed changes

Add new settingBreakpoint() API for when thread is null

2b019b9

Update copyrights

0256b41

alexmenkov approved these changes Apr 22, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2025

lmesnik approved these changes Apr 22, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Apr 22, 2025

openjdk bot closed this Apr 22, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication#24768

8355071: Fix nsk/jdi test to not require lookup of main thread in order to set the breakpoint used for communication#24768
plummercj wants to merge 18 commits intoopenjdk:masterfrom
plummercj:8355071_bp_for_com

plummercj commented Apr 19, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Apr 19, 2025

Uh oh!

openjdk bot commented Apr 19, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Apr 19, 2025

Uh oh!

plummercj commented Apr 19, 2025

Uh oh!

sendaoYan left a comment

Uh oh!

plummercj commented Apr 19, 2025

Uh oh!

mlbridge bot commented Apr 21, 2025 •

edited

Loading

Uh oh!

lmesnik left a comment

Uh oh!

lmesnik Apr 21, 2025

Uh oh!

plummercj Apr 21, 2025

Uh oh!

plummercj commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

plummercj commented Apr 19, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 19, 2025

Uh oh!

openjdk bot commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 19, 2025

Uh oh!

plummercj commented Apr 19, 2025

Uh oh!

sendaoYan left a comment

Choose a reason for hiding this comment

Uh oh!

plummercj commented Apr 19, 2025

Uh oh!

mlbridge bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

lmesnik left a comment

Choose a reason for hiding this comment

Uh oh!

lmesnik Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

plummercj Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

plummercj commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

plummercj commented Apr 19, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 19, 2025 •

edited

Loading

mlbridge bot commented Apr 21, 2025 •

edited

Loading