Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8261413: Shenandoah: Disable class-unloading in I-U mode #2477

Closed
wants to merge 3 commits into from
Closed

8261413: Shenandoah: Disable class-unloading in I-U mode #2477

wants to merge 3 commits into from
+5 −0

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Feb 9, 2021 •
edited by openjdk bot
Loading

JDK-8261341 describes a serious problem with I-U mode and class-unloading. Let's disable class-unloading in I-U for now as a workaround.

Testing:

  • hotspot_gc_shenandoah
  • tier1 (+UseShenandoahGC +IU)
  • runtime/CreateMirror/ArraysNewInstanceBug.java (+UseShenandoahGC +IU +aggressive) many times in a row w/o failure

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261413: Shenandoah: Disable class-unloading in I-U mode

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2477/head:pull/2477
$ git checkout pull/2477

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@rkennke The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Feb 9, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2021 •
edited
Loading

Webrevs

shipilev
shipilev suggested changes Feb 9, 2021
View reviewed changes
src/hotspot/share/gc/shenandoah/mode/shenandoahIUMode.cpp Outdated
@@ -34,6 +34,12 @@
#include "runtime/java.hpp"

void ShenandoahIUMode::initialize_flags() const {
// See: https://bugs.openjdk.java.net/browse/JDK-8261341
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment, as the message prints it out.

src/hotspot/share/gc/shenandoah/mode/shenandoahIUMode.cpp Outdated
@@ -34,6 +34,12 @@
#include "runtime/java.hpp"

void ShenandoahIUMode::initialize_flags() const {
// See: https://bugs.openjdk.java.net/browse/JDK-8261341
if (FLAG_IS_CMDLINE(ClassUnloading) && ClassUnloading) {
log_warning(gc)("Shenandoah I-U mode forces -XX:-ClassUnloading, for decails, see https://bugs.openjdk.java.net/browse/JDK-8261341");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Shenandoah I-U mode sets -XX:-ClassUnloading; see JDK-8261341 for details"

@openjdk
Copy link

openjdk bot commented Feb 9, 2021 •
edited
Loading

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261413: Shenandoah: Disable class-unloading in I-U mode

Reviewed-by: shade, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • 6badd22: 8261351: Create implementation for NSAccessibilityRadioButton protocol
  • 849f4c0: 8260291: The case instruction is not visible in dark mode
  • 2e610f5: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles
  • 3882fda: 8260414: Remove unused set_single_threaded_mode() method in task executor
  • c6eedda: 8261500: Shenandoah: reconsider region live data memory ordering
  • df0897e: 8261504: Shenandoah: reconsider ShenandoahJavaThreadsIterator::claim memory ordering
  • 745c0b9: 8261493: Shenandoah: reconsider bitmap access memory ordering
  • 4642730: 8261496: Shenandoah: reconsider pacing updates memory ordering
  • 7c93159: 8261503: Shenandoah: reconsider verifier memory ordering
  • ... and 76 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 9, 2021
@rkennke
Copy link
Contributor Author

rkennke commented Feb 16, 2021

/integrate

@openjdk openjdk bot closed this Feb 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2021
@openjdk
Copy link

openjdk bot commented Feb 16, 2021

@rkennke Since your change was applied there have been 86 commits pushed to the master branch:

  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • 6badd22: 8261351: Create implementation for NSAccessibilityRadioButton protocol
  • 849f4c0: 8260291: The case instruction is not visible in dark mode
  • 2e610f5: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles
  • 3882fda: 8260414: Remove unused set_single_threaded_mode() method in task executor
  • c6eedda: 8261500: Shenandoah: reconsider region live data memory ordering
  • df0897e: 8261504: Shenandoah: reconsider ShenandoahJavaThreadsIterator::claim memory ordering
  • 745c0b9: 8261493: Shenandoah: reconsider bitmap access memory ordering
  • 4642730: 8261496: Shenandoah: reconsider pacing updates memory ordering
  • 7c93159: 8261503: Shenandoah: reconsider verifier memory ordering
  • ... and 76 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

Your commit was automatically rebased without conflicts.

Pushed as commit e2d52ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengyu123 zhengyu123 zhengyu123 approved these changes

@shipilev shipilev shipilev approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkennke @shipilev @zhengyu123