8354484: SIGSEGV when supertype of an AOT-cached class is excluded

[iklam]

Since JDK-8353014, some classes that are loaded inside LambdaFormInvokers::regenerate_holder_classes() are marked as "AOT tooling classes". These classes are excluded from the AOT configuration file (which is generated at the end of the training run).

However, in the training run, application threads can run in parallel of LambdaFormInvokers::regenerate_holder_classes() and could load a subtype C of an "AOT tooling class" S.

This bug happened because C is included in the AOT configuration file, but Sis excluded.

The fix in this PR -- for any C that is included, we also include all of its super types, even for the super types that are marked as "AOT tooling classes".

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354484: SIGSEGV when supertype of an AOT-cached class is excluded (Bug - P3)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24780/head:pull/24780
$ git checkout pull/24780

Update a local copy of the PR:
$ git checkout pull/24780
$ git pull https://git.openjdk.org/jdk.git pull/24780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24780

View PR using the GUI difftool:
$ git pr show -t 24780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24780.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354484: SIGSEGV when supertype of an AOT-cached class is excluded

Reviewed-by: ccheung, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 7cd084c: 8350442: Update copyright
• bcc33d5: 8352504: RISC-V: implement and enable CMoveI/L
• 50358d1: 8354929: ZGC: Update collection stats while holding page allocator lock
• ... and 16 more: https://git.openjdk.org/jdk/compare/1526dd81d9b5bf4abaac1546c370cf7a056d01dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7d48d141)

[calvinccheung]

LGTM.

[shipilev]

Looks reasonable.

[iklam]

Thanks @calvinccheung @shipilev for the review
/integrate

[openjdk]

Going to push as commit e020752.
Since your change was applied there have been 31 commits pushed to the master branch:

• 594b265: 8350126: Regression ~3% on Crypto-ChaCha20Poly1305.encrypt for MacOSX aarch64
• d783a94: 8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int'
• 6a31061: 8354248: Open source several AWT GridBagLayout and List tests
• ... and 28 more: https://git.openjdk.org/jdk/compare/1526dd81d9b5bf4abaac1546c370cf7a056d01dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit e020752.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.