Skip to content

Conversation

@myankelev
Copy link
Member

@myankelev myankelev commented Apr 23, 2025

I could not replicate the issue after more than 64000 runs. However, I have done the following to increase stability and added logs in case this happens again.

Changes:

  • Specifically binding the client to the loopback address
  • Added additional debug logging

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24823/head:pull/24823
$ git checkout pull/24823

Update a local copy of the PR:
$ git checkout pull/24823
$ git pull https://git.openjdk.org/jdk.git pull/24823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24823

View PR using the GUI difftool:
$ git pr show -t 24823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24823.diff

Using Webrev

Link to Webrev Comment

…on refused

* Increased stability wiht specifically binding the client to the loopback address
* Added additional debug logging
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2025

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277424: javax/net/ssl/TLSCommon/TLSTest.java  fails with connection refused

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 461 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title JDK-8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused 8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused Apr 23, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2025
@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 23, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 1, 2025
@rhalade
Copy link
Member

rhalade commented May 1, 2025

This bug could be closed as cannot reproduce but the enhancement you did is also good one to have. LGTM.

@myankelev
Copy link
Member Author

myankelev commented May 1, 2025

@rhalade thank you.

@myankelev
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 1, 2025
@openjdk
Copy link

openjdk bot commented May 1, 2025

@myankelev
Your change (at version a00505c) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

rhalade commented May 1, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented May 1, 2025

Going to push as commit 6b553ac.
Since your change was applied there have been 466 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 1, 2025
@openjdk openjdk bot closed this May 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 1, 2025
@openjdk
Copy link

openjdk bot commented May 1, 2025

@rhalade @myankelev Pushed as commit 6b553ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants