-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8355432: Remove CompileTask from SA #24832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8355432: Remove CompileTask from SA #24832
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/label compiler add |
|
@plummercj
|
|
/label hotspot-compiler add |
|
@plummercj
|
|
/label hotspot-compiler |
|
@plummercj |
plummercj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Thanks for reviews! I think we are good to go. /integrate |
|
Going to push as commit 0edd018.
Your commit was automatically rebased without conflicts. |
A lot of SA infrastructure was added to support SA compiler replay with JDK-7088955. With JDK-8315488, we got rid from the most of it.
CompileTaskseems to be left behind. Nothing uses it in SA now.Now, for Leyden, we want to massage
CompileTaskfor better performance and reliability (JDK-8231269), and keepingCompileTaskin SA would require us to implement a whole bunch of complicated, but unnecessary code.So, it would be good to purge
CompileTaskfrom SA.Note that I left the related
vmStructsdefinitions, because async-profiler uses those; I think to see which methods current compiler is compiling. That use looks safe, as it polls the task from the already set up ciEnv. async-profiler would need to re-adjust after JDK-8231269 makes relevant changes invmStructs. This PR frees us from doing the same thing in SA.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24832/head:pull/24832$ git checkout pull/24832Update a local copy of the PR:
$ git checkout pull/24832$ git pull https://git.openjdk.org/jdk.git pull/24832/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24832View PR using the GUI difftool:
$ git pr show -t 24832Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24832.diff
Using Webrev
Link to Webrev Comment