Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Apr 23, 2025

A lot of SA infrastructure was added to support SA compiler replay with JDK-7088955. With JDK-8315488, we got rid from the most of it. CompileTask seems to be left behind. Nothing uses it in SA now.

Now, for Leyden, we want to massage CompileTask for better performance and reliability (JDK-8231269), and keeping CompileTask in SA would require us to implement a whole bunch of complicated, but unnecessary code.

So, it would be good to purge CompileTask from SA.

Note that I left the related vmStructs definitions, because async-profiler uses those; I think to see which methods current compiler is compiling. That use looks safe, as it polls the task from the already set up ciEnv. async-profiler would need to re-adjust after JDK-8231269 makes relevant changes in vmStructs. This PR frees us from doing the same thing in SA.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355432: Remove CompileTask from SA (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24832/head:pull/24832
$ git checkout pull/24832

Update a local copy of the PR:
$ git checkout pull/24832
$ git pull https://git.openjdk.org/jdk.git pull/24832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24832

View PR using the GUI difftool:
$ git pr show -t 24832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24832.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355432: Remove CompileTask from SA

Reviewed-by: cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2025
@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@shipilev The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 23, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2025

Webrevs

@plummercj
Copy link
Contributor

/label compiler add

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@plummercj
The label add is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@plummercj
Copy link
Contributor

/label hotspot-compiler add

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@plummercj
The label add is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@plummercj
Copy link
Contributor

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 23, 2025
@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@plummercj
The hotspot-compiler label was successfully added.

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 23, 2025
@shipilev
Copy link
Member Author

Thanks for reviews! I think we are good to go.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

Going to push as commit 0edd018.
Since your change was applied there have been 44 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2025
@openjdk openjdk bot closed this Apr 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2025
@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@shipilev Pushed as commit 0edd018.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants