8355473: Clean up x86 globals/VM_Version after 32-bit x86 removal

[shipilev]

This cleanup targets globals_x86.* and vmVersion_x86.*.

Additional testing:

• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355473: Clean up x86 globals/VM_Version after 32-bit x86 removal (Sub-task - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24844/head:pull/24844
$ git checkout pull/24844

Update a local copy of the PR:
$ git checkout pull/24844
$ git pull https://git.openjdk.org/jdk.git pull/24844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24844

View PR using the GUI difftool:
$ git pr show -t 24844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24844.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355473: Clean up x86 globals/VM_Version after 32-bit x86 removal

Reviewed-by: chagedorn, coleenp, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 751e039: 8355235: Clean out old versions from Tools.gmk
• 0edd018: 8355432: Remove CompileTask from SA
• 356c4d9: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent
• ... and 11 more: https://git.openjdk.org/jdk/compare/7bfbb9a51533f30613cacd47433ba709353ce3d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2bc8338e)

[chhagedorn]

Looks good to me.

[coleenp]

Looks good.

[shipilev]

Thanks! Testing is green, so I am going to integrate sometime tomorrow.

[TheShermanTanker]

Something HotSpot related that's actually easy enough for me to understand and help review for once, that's a breath of fresh air

[shipilev]

Thank you all!

/integrate

[openjdk]

Going to push as commit dbd2fb0.
Since your change was applied there have been 24 commits pushed to the master branch:

• 70030ba: 8354803: ALL_64_BITS is the same across platforms
• f27fc01: 8355576: Problem list compiler/c2/TestVerifyConstraintCasts.java until JDK-8355574 is fixed
• ed60403: 8346836: C2: Verify CastII/CastLL bounds at runtime
• ... and 21 more: https://git.openjdk.org/jdk/compare/7bfbb9a51533f30613cacd47433ba709353ce3d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit dbd2fb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.