Skip to content

8355492: MissedOptCastII is missing UnlockDiagnosticVMOptions flag#24849

Closed
marc-chevalier wants to merge 1 commit intoopenjdk:masterfrom
marc-chevalier:fix/add-UnlockDiagnosticVMOptions-to-MissedOptCastII
Closed

8355492: MissedOptCastII is missing UnlockDiagnosticVMOptions flag#24849
marc-chevalier wants to merge 1 commit intoopenjdk:masterfrom
marc-chevalier:fix/add-UnlockDiagnosticVMOptions-to-MissedOptCastII

Conversation

@marc-chevalier
Copy link
Member

@marc-chevalier marc-chevalier commented Apr 24, 2025

As the title says, let's just add the flag! Sorry, my bad.

It now works on my machine.

Thanks,
Marc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355492: MissedOptCastII is missing UnlockDiagnosticVMOptions flag (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24849/head:pull/24849
$ git checkout pull/24849

Update a local copy of the PR:
$ git checkout pull/24849
$ git pull https://git.openjdk.org/jdk.git pull/24849/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24849

View PR using the GUI difftool:
$ git pr show -t 24849

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24849.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2025

👋 Welcome back mchevalier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@marc-chevalier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355492: MissedOptCastII is missing UnlockDiagnosticVMOptions flag

Reviewed-by: rcastanedalo, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@marc-chevalier The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 24, 2025
@marc-chevalier marc-chevalier marked this pull request as ready for review April 24, 2025 13:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2025

Webrevs

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 24, 2025
@marc-chevalier
Copy link
Member Author

/integrate

Thanks @robcasloz!

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@marc-chevalier
Copy link
Member Author

Oh, and thanks @chhagedorn as well!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 24, 2025
@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@marc-chevalier
Your change (at version 3fb2bb7) is now ready to be sponsored by a Committer.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

Going to push as commit 0537c69.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2025
@openjdk openjdk bot closed this Apr 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 24, 2025
@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@TobiHartmann @marc-chevalier Pushed as commit 0537c69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants