8355492: MissedOptCastII is missing UnlockDiagnosticVMOptions flag#24849
Conversation
|
👋 Welcome back mchevalier! A progress list of the required criteria for merging this PR into |
|
@marc-chevalier This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@marc-chevalier The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
robcasloz
left a comment
There was a problem hiding this comment.
Looks good, and trivial.
|
/integrate Thanks @robcasloz! |
|
Oh, and thanks @chhagedorn as well! |
|
@marc-chevalier |
|
Going to push as commit 0537c69. |
|
@TobiHartmann @marc-chevalier Pushed as commit 0537c69. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As the title says, let's just add the flag! Sorry, my bad.
It now works on my machine.
Thanks,
Marc
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24849/head:pull/24849$ git checkout pull/24849Update a local copy of the PR:
$ git checkout pull/24849$ git pull https://git.openjdk.org/jdk.git pull/24849/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24849View PR using the GUI difftool:
$ git pr show -t 24849Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24849.diff
Using Webrev
Link to Webrev Comment