8355558: SJIS.java test is always ignored

[naotoj]

Stemmed from this PR: #24838
After JEP 400, file.encoding is always UTF-8, so the test was never run. Using native.encoding is appropriate so that the intention of the initial test will hold. Tested on an English Windows in which the system locale is set to Japanese(Japan), and confirmed it succeeded without SkippedException.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355558: SJIS.java test is always ignored (Bug - P4)

Reviewers

• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24881/head:pull/24881
$ git checkout pull/24881

Update a local copy of the PR:
$ git checkout pull/24881
$ git pull https://git.openjdk.org/jdk.git pull/24881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24881

View PR using the GUI difftool:
$ git pr show -t 24881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24881.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355558: SJIS.java test is always ignored

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 2785570: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests
• 4b88029: 8355439: Some hotspot/jtreg/serviceability/sa/* tests fail on static JDK due to explicit checks for shared libraries in process memory map
• d8f012e: 8305186: Reference.waitForReferenceProcessing should be more accessible to tests
• ... and 16 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (76aac517)
• 00: Full (670228c7)

[bplb]

Maybe don't use wildcard import?

[naotoj]

Fixed.

[bplb]

Thanks!

[bplb]

I don't have good knowledge of the encodings, but code-wise this looks fine.

[naotoj]

Thank you for the review!
/integrate

[openjdk]

Going to push as commit c0dc314.
Since your change was applied there have been 42 commits pushed to the master branch:

• b1e778d: 8354686: [AIX] now ubsan is possible
• 66358fa: 8355616: Incorrect ifdef in compilationMemoryStatistic.cpp
• e7a4162: 8355717: Problem list tests until JDK-8355708 is fixed
• ... and 39 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit c0dc314.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.