8355649: Missing ResourceMark in ExceptionMark::check_no_pending_exception

[lmesnik]

I find during test development.
I don't think that separate regression test is needed here.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355649: Missing ResourceMark in ExceptionMark::check_no_pending_exception (Bug - P4)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24896/head:pull/24896
$ git checkout pull/24896

Update a local copy of the PR:
$ git checkout pull/24896
$ git pull https://git.openjdk.org/jdk.git pull/24896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24896

View PR using the GUI difftool:
$ git pr show -t 24896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24896.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355649: Missing ResourceMark in ExceptionMark::check_no_pending_exception

Reviewed-by: jsjolen, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 3140de4: 8345125: Aarch64: Add aarch64 backend for Float16 scalar operations
• a05ff55: 8355657: RISC-V: Improve PrintOptoAssembly output of vector-scalar instructions
• 7df1bfe: 8354811: clock_tics_per_sec code duplication between os_linux and os_posix
• ... and 31 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6c333648)

[johan-sjolen]

Hi Leonid,

Where is the resource allocation? I can't find it :).

Thanks,
Johan

[lmesnik]

The print requires allocation.
As I understand caller should add it and not print() itself.

[johan-sjolen]

The print requires allocation. As I understand caller should add it and not print() itself.

How do you know that it requires allocation?

[johan-sjolen]

Here's the resource allocation:

st->print_cr("%s ", internal_name()); // klass.cpp:1006

And it comes with a small comment: // Caller needs ResourceMark

[shipilev]

Looks okay. It is common to require ResourceMark around printing statements. And in here, we are going to fail with fatal, so VM is going down anyway.

[lmesnik]

/integrate

[openjdk]

Going to push as commit af4388a.
Since your change was applied there have been 46 commits pushed to the master branch:

• acd93df: 8355080: java.base/jdk.internal.foreign.SystemLookup.find() doesn't work on static JDK
• 2f84480: 8354053: Remove unused JavaIOFilePermissionAccess
• a090aa3: 8354902: Change to Visual Studio 17.13.2 for building on Windows at Oracle
• ... and 43 more: https://git.openjdk.org/jdk/compare/370e6113de30fd1bc596b5fbf7bd00f97e689f4f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit af4388a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.