Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253000: Remove redundant MAKE_SUBDIR argument #249

Conversation

@adamfarley
Copy link

@adamfarley adamfarley commented Sep 18, 2020

As part of JDK-8244044, MAKE_SUBDIR is no longer used in DeclareRecipesForPhase inside MakeSupport.gmk.

Therefore, it seems sensible to modify the instances where this is passed to DeclareRecipesForPhase, and to remove references to it from the associated MakeSupport.gmk comment.

Bug: https://bugs.openjdk.java.net/browse/JDK-8253000


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/249/head:pull/249
$ git checkout pull/249

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2020

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@adamfarley The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@openjdk openjdk bot added the build label Sep 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2020

Webrevs

Loading

Copy link
Member

@erikj79 erikj79 left a comment

Looks good, thanks for cleaning this up!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253000: Remove redundant MAKE_SUBDIR argument

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 289 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 18, 2020
@adamfarley
Copy link
Author

@adamfarley adamfarley commented Oct 2, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@adamfarley
Your change (at version bb33789) is now ready to be sponsored by a Committer.

Loading

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 7, 2020

/sponsor

Loading

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@shipilev @adamfarley Since your change was applied there have been 332 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9543d76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Oct 7, 2020

Thanks @shipilev :)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants