8355648: Thread.SpinAcquire()'s lock name parameter is not used

[zhengyu123]

Please review this trivial change that removes unused lock name parameter.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355648: Thread.SpinAcquire()'s lock name parameter is not used (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24901/head:pull/24901
$ git checkout pull/24901

Update a local copy of the PR:
$ git checkout pull/24901
$ git pull https://git.openjdk.org/jdk.git pull/24901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24901

View PR using the GUI difftool:
$ git pr show -t 24901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24901.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355648: Thread.SpinAcquire()'s lock name parameter is not used

Reviewed-by: shade, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• a7359a5: 8354453: Don't strcpy in os::strdup, use memcpy instead
• b0c3485: 8348282: Add option for syntax highlighting in javadoc snippets
• 2447b98: 8355498: [AIX] Adapt code for C++ VLA rule
• ... and 11 more: https://git.openjdk.org/jdk/compare/21b0f5ea153c633de7f09bdb0399308c890f7e43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7c55fab9)

[shipilev]

Looks reasonable. Not trivial, though. I think the intent was to give the diagnostic messages when we are e.g. spinning too much? Does not seem to worth it for the spin-locks that are supposed to be very fast.

[coleenp]

I think this is fine. There are only a couple of these locks left and it seems like we should be able to use some other locking mechanism already in the VM for these critical sections and remove this lock implementation that I want to forget still exists.

[zhengyu123]

/integrate

Thanks, @shipilev and @coleenp

[openjdk]

Going to push as commit 62ef706.
Since your change was applied there have been 25 commits pushed to the master branch:

• 1fd136c: 8354335: No longer deprecate wrapper class constructors for removal
• 62d165d: 8355669: Add static-jdk-bundles make target
• af4388a: 8355649: Missing ResourceMark in ExceptionMark::check_no_pending_exception
• ... and 22 more: https://git.openjdk.org/jdk/compare/21b0f5ea153c633de7f09bdb0399308c890f7e43...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 62ef706.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

I'm pretty sure the point of the name was to give something to inspect whilst debugging a hang.