8355472: Clean up x86 nativeInst after 32-bit x86 removal

[mhaessig]

This PR cleans up code 32-bit x86 code in nativeInst_x86.* files.

Testing:

• tier1 through tier4 on x86 plus Oracle internal testing

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355472: Clean up x86 nativeInst after 32-bit x86 removal (Sub-task - P4)

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer) Review applies to 4bbfc501
• Aleksey Shipilev (@shipilev - Reviewer)
• Julian Waters (@TheShermanTanker - Committer) Review applies to 4bbfc501

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24911/head:pull/24911
$ git checkout pull/24911

Update a local copy of the PR:
$ git checkout pull/24911
$ git pull https://git.openjdk.org/jdk.git pull/24911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24911

View PR using the GUI difftool:
$ git pr show -t 24911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24911.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355472: Clean up x86 nativeInst after 32-bit x86 removal

Reviewed-by: shade, rcastanedalo, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• 31e70e4: 8355697: Create windows devkit on wsl and msys2
• 108078a: 8338194: ubsan: mulnode.cpp:862:59: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'
• 841989b: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595
• ... and 70 more: https://git.openjdk.org/jdk/compare/be6e4406d8c9024bb368ed9dc22d4a6df2a0846a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @shipilev, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f2382dce)
• 00: Full (4bbfc501)

[robcasloz]

Looks good, thanks!

[shipilev]

Looks good! I have a tiny readability suggestion. Feel free to ignore it:

[TheShermanTanker]

Looks good

[shipilev]

Ship it.

[mhaessig]

Thank you for your reviews!

/integrate

[openjdk]

@mhaessig
Your change (at version f2382dc) is now ready to be sponsored by a Committer.

[robcasloz]

/sponsor

[openjdk]

Going to push as commit 6a0c24f.
Since your change was applied there have been 73 commits pushed to the master branch:

• 31e70e4: 8355697: Create windows devkit on wsl and msys2
• 108078a: 8338194: ubsan: mulnode.cpp:862:59: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'
• 841989b: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595
• ... and 70 more: https://git.openjdk.org/jdk/compare/be6e4406d8c9024bb368ed9dc22d4a6df2a0846a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz @mhaessig Pushed as commit 6a0c24f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.