8355594: Warnings occur when building with clang and enabling ubsan

[MBaesken]

When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or Linux), we get the following warnings :

warning: unknown warning option '-Wno-stringop-truncation'; did you mean '-Wno-string-concatenation'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-format-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-stringop-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355594: Warnings occur when building with clang and enabling ubsan (Bug - P4)

Reviewers

• Joachim Kern (@JoKern65 - Committer) Review applies to dbfcece2
• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer) Review applies to dbfcece2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24924/head:pull/24924
$ git checkout pull/24924

Update a local copy of the PR:
$ git checkout pull/24924
$ git pull https://git.openjdk.org/jdk.git pull/24924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24924

View PR using the GUI difftool:
$ git pr show -t 24924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24924.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355594: Warnings occur when building with clang and enabling ubsan

Reviewed-by: erikj, jkern, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• edf8ce8: 8355739: AssertionError: Invalid CPU feature name after 8353786
• 6a0c24f: 8355472: Clean up x86 nativeInst after 32-bit x86 removal
• 31e70e4: 8355697: Create windows devkit on wsl and msys2
• ... and 15 more: https://git.openjdk.org/jdk/compare/b1e778d9d2ad13ee5f1ed629a8805008580f86c0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (72bec244)
• 00: Full (dbfcece2)

[JoKern65]

LGTM

[magicus]

Just for the sake of my sanity, can you reorder the -Wno-* options in alphabetical order?

[MBaesken]

Done ! Need a re-review now .

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 9f42ff8.
Since your change was applied there have been 18 commits pushed to the master branch:

• edf8ce8: 8355739: AssertionError: Invalid CPU feature name after 8353786
• 6a0c24f: 8355472: Clean up x86 nativeInst after 32-bit x86 removal
• 31e70e4: 8355697: Create windows devkit on wsl and msys2
• ... and 15 more: https://git.openjdk.org/jdk/compare/b1e778d9d2ad13ee5f1ed629a8805008580f86c0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 9f42ff8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.